Stream: git-wasmtime

Topic: wasmtime / PR #6197 add a wasi-test to show a dir_fd alwa...

Wasmtime GitHub notifications bot (Apr 11 2023 at 17:49):

pchickey opened PR #6197 from bytecodealliance:pch/wasi-tests-dir-fd-errors to bytecodealliance:main:

This is a conformance test for the current behavior of preview 1 in wasi-common. It is debatable whether this is the right errno, I think for most of these ERRNO_ISDIR would be more descriptive, but this is the behavior as implemented.

cc @dicej

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 11 2023 at 17:49):

pchickey requested alexcrichton for a review on PR #6197.

Wasmtime GitHub notifications bot (Apr 11 2023 at 17:49):

pchickey requested wasmtime-core-reviewers for a review on PR #6197.

Wasmtime GitHub notifications bot (Apr 11 2023 at 17:49):

pchickey requested sunfishcode for a review on PR #6197.

Wasmtime GitHub notifications bot (Apr 11 2023 at 17:49):

pchickey requested wasmtime-core-reviewers for a review on PR #6197.

Wasmtime GitHub notifications bot (Apr 11 2023 at 17:50):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 11 2023 at 18:45):

sunfishcode submitted PR review.

Wasmtime GitHub notifications bot (Apr 11 2023 at 20:29):

pchickey updated PR #6197.

Wasmtime GitHub notifications bot (Apr 11 2023 at 21:14):

pchickey updated PR #6197.

Wasmtime GitHub notifications bot (Apr 11 2023 at 21:53):

pchickey updated PR #6197.

Wasmtime GitHub notifications bot (Apr 12 2023 at 17:35):

pchickey merged PR #6197.

Last updated: Dec 23 2024 at 12:05 UTC