Stream: git-wasmtime

Topic: wasmtime / PR #6195 feat: align wasi-http with component ...

Wasmtime GitHub notifications bot (Apr 11 2023 at 06:40):

eduardomourar opened PR #6195 from eduardomourar:feat/wasi-http-align-component to bytecodealliance:main.

Wasmtime GitHub notifications bot (Apr 17 2023 at 07:58):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Apr 17 2023 at 13:14):

rvolosatovs created PR review comment:

Does this really belong in wasi-http crate or should it be living alongside the existing https://docs.wasmtime.dev/api/wasi_common/table/struct.Table.html in wasi_common? Should there be a wasi_common::component::table::Table if this is component-model specific?

Wasmtime GitHub notifications bot (Apr 17 2023 at 13:14):

rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Apr 17 2023 at 13:16):

rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Apr 17 2023 at 13:16):

rvolosatovs created PR review comment:

Wasmtime GitHub notifications bot (Apr 17 2023 at 13:18):

rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Apr 17 2023 at 13:18):

rvolosatovs created PR review comment:

Aren't these clones redundant? If you didn't call iter() you could just move these instead, since the vector is moved into this function, right?

Wasmtime GitHub notifications bot (Apr 17 2023 at 13:23):

rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Apr 17 2023 at 13:23):

rvolosatovs created PR review comment:

This can be cleaner expressed with iterator operations and collect, but if you want to keep the for loop

for (key, value) in entries {
   map.insert(key, vec![value])
}

it's just this, right?

Wasmtime GitHub notifications bot (Apr 17 2023 at 13:25):

rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Apr 17 2023 at 13:25):

rvolosatovs created PR review comment:

How about extracting this to a let body = req.body().unwrap_or_else(/* ... */) for clarity?

Wasmtime GitHub notifications bot (Apr 17 2023 at 16:03):

eduardomourar submitted PR review.

Wasmtime GitHub notifications bot (Apr 17 2023 at 16:03):

eduardomourar created PR review comment:

yes, when wasmtime supports wasi preview2, the wasi common here will most likely contain the table (following the preview2-prototyping approach). until then, i just copied this over and made some small tweaks.

Wasmtime GitHub notifications bot (Apr 17 2023 at 16:09):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Apr 18 2023 at 08:53):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Apr 18 2023 at 15:21):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Apr 18 2023 at 15:51):

eduardomourar edited PR #6195.

Wasmtime GitHub notifications bot (Apr 18 2023 at 15:53):

eduardomourar has marked PR #6195 as ready for review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 15:53):

eduardomourar requested alexcrichton for a review on PR #6195.

Wasmtime GitHub notifications bot (Apr 18 2023 at 15:53):

eduardomourar requested wasmtime-core-reviewers for a review on PR #6195.

Wasmtime GitHub notifications bot (Apr 18 2023 at 16:18):

eduardomourar edited PR #6195:

In the context of wasi-http, this PR will prepare the ground for the migration from the preview2-prototyping repo to wasmtime. A table is being defined to simulate the future resource type. Additionally, it will simplify using Component Linker with the wasi-http.

<details>
<summary>Usage example with WASI Preview2</summary>

use host::{command::wasi, WasiCtx};
use std::{any::Any, pin::Pin};
use wasi_cap_std_sync::WasiCtxBuilder;
use wasmtime::{
    component::{Component, Linker},
    Config, Engine, Store,
};
use wasmtime_wasi_http::{common, WasiHttpCtx};

pub struct Ctx {
    wasi: WasiCtx,
    http: WasiHttpCtx,
}

pub fn add_to_linker<T: Send>(
    l: &mut wasmtime::component::Linker<T>,
    f: impl (Fn(&mut T) -> &mut WasiCtx) + Copy + Send + Sync + 'static,
) -> anyhow::Result<()> {
    wasi::wall_clock::add_to_linker(l, f)?;
    wasi::monotonic_clock::add_to_linker(l, f)?;
    wasi::timezone::add_to_linker(l, f)?;
    wasi::instance_monotonic_clock::add_to_linker(l, f)?;
    wasi::instance_wall_clock::add_to_linker(l, f)?;
    wasi::filesystem::add_to_linker(l, f)?;
    wasi::poll::add_to_linker(l, f)?;
    wasi::random::add_to_linker(l, f)?;
    wasi::exit::add_to_linker(l, f)?;
    wasi::environment::add_to_linker(l, f)?;
    wasi::preopens::add_to_linker(l, f)?;
    Ok(())
}

struct WritePipe {}

impl common::OutputStream for WritePipe {
    fn as_any(&self) -> &dyn Any {
        self
    }

    fn write(&mut self, buf: &[u8]) -> Result<u64, common::Error> {
        println!("{}", String::from_utf8_lossy(buf).into_owned());
        Ok(buf.len().try_into()?)
    }

    fn write_zeroes(&mut self, nelem: u64) -> Result<u64, common::Error> {
        Ok(nelem)
    }
    fn readable(&self) -> Result<(), common::Error> {
        Ok(())
    }
    fn writable(&self) -> Result<(), common::Error> {
        Ok(())
    }
}

#[tokio::main]
async fn main() -> anyhow::Result<()> {
    let mut wasi = WasiCtxBuilder::new().inherit_stdio().build();
    let mut http = WasiHttpCtx::new();
    http.set_stdout(Box::new(WritePipe {}));
    http.set_stderr(Box::new(WritePipe {}));
    let mut config = Config::new();
    config.wasm_backtrace_details(wasmtime::WasmBacktraceDetails::Enable);
    config.wasm_component_model(true);
    config.wasm_multi_memory(true);
    config.async_support(true);

    let engine = Engine::new(&config)?;
    let component = Component::from_file(&engine, "component.wasm")?;
    let mut store = Store::new(&engine, Ctx { wasi, http });
    let mut linker = Linker::new(&engine);

    add_to_linker(&mut linker, |ctx: &mut Ctx| &mut ctx.wasi)?;
    wasmtime_wasi_http::add_to_component_linker(&mut linker, |ctx: &mut Ctx| &mut ctx.http)?;

    let (wasi, _instance) =
        wasi::Command::instantiate_async(&mut store, &component, &linker).await?;
    let result = wasi
        .call_main(&mut store, &[])
        .await
        .map_err(anyhow::Error::from)?;

    if result.is_err() {
        anyhow::bail!(
            "command returned with failing exit status: {:?}",
            result.err().unwrap()
        );
    }

    Ok(())
}

</details>

Wasmtime GitHub notifications bot (Apr 18 2023 at 16:19):

eduardomourar edited PR #6195:

In the context of wasi-http, this PR will prepare the ground for the migration from the preview2-prototyping repo to wasmtime. A table is being defined to simulate the future resource type. Additionally, it will simplify using Component Linker with the wasi-http module.

<details>
<summary>Usage example with WASI Preview2</summary>

use host::{command::wasi, WasiCtx};
use std::{any::Any, pin::Pin};
use wasi_cap_std_sync::WasiCtxBuilder;
use wasmtime::{
    component::{Component, Linker},
    Config, Engine, Store,
};
use wasmtime_wasi_http::{common, WasiHttpCtx};

pub struct Ctx {
    wasi: WasiCtx,
    http: WasiHttpCtx,
}

pub fn add_to_linker<T: Send>(
    l: &mut wasmtime::component::Linker<T>,
    f: impl (Fn(&mut T) -> &mut WasiCtx) + Copy + Send + Sync + 'static,
) -> anyhow::Result<()> {
    wasi::wall_clock::add_to_linker(l, f)?;
    wasi::monotonic_clock::add_to_linker(l, f)?;
    wasi::timezone::add_to_linker(l, f)?;
    wasi::instance_monotonic_clock::add_to_linker(l, f)?;
    wasi::instance_wall_clock::add_to_linker(l, f)?;
    wasi::filesystem::add_to_linker(l, f)?;
    wasi::poll::add_to_linker(l, f)?;
    wasi::random::add_to_linker(l, f)?;
    wasi::exit::add_to_linker(l, f)?;
    wasi::environment::add_to_linker(l, f)?;
    wasi::preopens::add_to_linker(l, f)?;
    Ok(())
}

struct WritePipe {}

impl common::OutputStream for WritePipe {
    fn as_any(&self) -> &dyn Any {
        self
    }

    fn write(&mut self, buf: &[u8]) -> Result<u64, common::Error> {
        println!("{}", String::from_utf8_lossy(buf).into_owned());
        Ok(buf.len().try_into()?)
    }

    fn write_zeroes(&mut self, nelem: u64) -> Result<u64, common::Error> {
        Ok(nelem)
    }
    fn readable(&self) -> Result<(), common::Error> {
        Ok(())
    }
    fn writable(&self) -> Result<(), common::Error> {
        Ok(())
    }
}

#[tokio::main]
async fn main() -> anyhow::Result<()> {
    let mut wasi = WasiCtxBuilder::new().inherit_stdio().build();
    let mut http = WasiHttpCtx::new();
    http.set_stdout(Box::new(WritePipe {}));
    http.set_stderr(Box::new(WritePipe {}));
    let mut config = Config::new();
    config.wasm_backtrace_details(wasmtime::WasmBacktraceDetails::Enable);
    config.wasm_component_model(true);
    config.wasm_multi_memory(true);
    config.async_support(true);

    let engine = Engine::new(&config)?;
    let component = Component::from_file(&engine, "component.wasm")?;
    let mut store = Store::new(&engine, Ctx { wasi, http });
    let mut linker = Linker::new(&engine);

    add_to_linker(&mut linker, |ctx: &mut Ctx| &mut ctx.wasi)?;
    wasmtime_wasi_http::add_to_component_linker(&mut linker, |ctx: &mut Ctx| &mut ctx.http)?;

    let (wasi, _instance) =
        wasi::Command::instantiate_async(&mut store, &component, &linker).await?;
    let result = wasi
        .call_main(&mut store, &[])
        .await
        .map_err(anyhow::Error::from)?;

    if result.is_err() {
        anyhow::bail!(
            "command returned with failing exit status: {:?}",
            result.err().unwrap()
        );
    }

    Ok(())
}

</details>

Wasmtime GitHub notifications bot (Apr 18 2023 at 16:59):

brendandburns submitted PR review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 16:59):

brendandburns created PR review comment:

remove dead code.

Wasmtime GitHub notifications bot (Apr 18 2023 at 17:00):

brendandburns submitted PR review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 17:00):

brendandburns created PR review comment:

Is there a reason for the rename?

Wasmtime GitHub notifications bot (Apr 18 2023 at 17:34):

eduardomourar submitted PR review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 17:34):

eduardomourar created PR review comment:

for this piece, we need to choose which errors we want to throw in place of others

Wasmtime GitHub notifications bot (Apr 18 2023 at 17:35):

eduardomourar submitted PR review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 17:35):

eduardomourar created PR review comment:

just to follow the pattern in the other modules, and also to show that there is a breaking change to the API

Wasmtime GitHub notifications bot (Apr 18 2023 at 18:28):

alexcrichton requested pchickey for a review on PR #6195.

Wasmtime GitHub notifications bot (Jul 31 2023 at 10:08):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 03 2023 at 22:56):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 03 2023 at 23:06):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 05 2023 at 15:14):

eduardomourar requested elliottt for a review on PR #6195.

Wasmtime GitHub notifications bot (Aug 05 2023 at 15:14):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 05 2023 at 15:14):

eduardomourar requested wasmtime-compiler-reviewers for a review on PR #6195.

Wasmtime GitHub notifications bot (Aug 06 2023 at 11:03):

eduardomourar edited PR #6195:

In the context of wasi-http, this PR will use the shared functionality from wasmtime-wasi will prepare the ground for the migration from the preview2-prototyping repo to wasmtime. A table is being defined to simulate the future resource type. Additionally, it will simplify using Component Linker with the wasi-http module.

<details>
<summary>Usage example with WASI Preview2</summary>

use wasmtime::{
    component::{Component, Linker},
    Config, Engine, Store,
};
use wasmtime_wasi::preview2::{
    command::Command, Table, WasiCtx, WasiCtxBuilder, WasiView,
};
use wasmtime_wasi_http::{WasiHttpCtx, WasiHttpView};

pub struct Ctx {
   table: Table,
    wasi: WasiCtx,
    http: WasiHttpCtx,
}

impl WasiView for Ctx {
    fn table(&self) -> &Table {
        &self.table
    }
    fn table_mut(&mut self) -> &mut Table {
        &mut self.table
    }
    fn ctx(&self) -> &WasiCtx {
        &self.wasi
    }
    fn ctx_mut(&mut self) -> &mut WasiCtx {
        &mut self.wasi
    }
}

impl WasiHttpView for Ctx {
    fn http_ctx(&self) -> &WasiHttpCtx {
        &self.http
    }
    fn http_ctx_mut(&mut self) -> &mut WasiHttpCtx {
        &mut self.http
    }
}

#[tokio::main]
async fn main() -> anyhow::Result<()> {
    let wasi = WasiCtxBuilder::new().inherit_stdio().build();
    let http = WasiHttpCtx::new();
    let mut config = Config::new();
    config.wasm_backtrace_details(wasmtime::WasmBacktraceDetails::Enable);
    config.wasm_component_model(true);
    config.async_support(true);

    let engine = Engine::new(&config)?;
    let component = Component::from_file(&engine, "component.wasm")?;
    let mut store = Store::new(&engine, Ctx { table, wasi, http });
    let mut linker = Linker::new(&engine);

    add_to_linker(&mut linker)?;
    wasmtime_wasi_http::add_to_component_linker(&mut linker)?;

    let (wasi, _instance) =
        wasi::Command::instantiate_async(&mut store, &component, &linker).await?;
    let result = wasi
        .call_main(&mut store, &[])
        .await
        .map_err(|e| anyhow::anyhow!("wasm failed with {e:?}"))?
        .map_err(|e| anyhow::anyhow!("command returned with failing exit status {e:?}"))?;

    Ok(())
}

</details>

Wasmtime GitHub notifications bot (Aug 06 2023 at 11:10):

eduardomourar requested wasmtime-default-reviewers for a review on PR #6195.

Wasmtime GitHub notifications bot (Aug 06 2023 at 11:10):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 06 2023 at 11:11):

eduardomourar submitted PR review.

Wasmtime GitHub notifications bot (Aug 06 2023 at 11:11):

eduardomourar created PR review comment:

we are using the shared table as provided by wasmtime-wasi.

Wasmtime GitHub notifications bot (Aug 10 2023 at 16:44):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 10 2023 at 17:24):

eduardomourar submitted PR review.

Wasmtime GitHub notifications bot (Aug 10 2023 at 17:26):

eduardomourar created PR review comment:

@pchickey , here is the part where we have a shared stream for both read and write. i solved by populating the table with both streams and just keeping their ids for later use.

Wasmtime GitHub notifications bot (Aug 11 2023 at 00:03):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Aug 11 2023 at 00:03):

elliottt created PR review comment:

Why remove the closure argument here? (That's what's causing the CI build failures currently.)

Wasmtime GitHub notifications bot (Aug 11 2023 at 01:53):

eduardomourar edited PR #6195:

In the context of wasi-http, this PR will use the shared functionality from wasmtime-wasi will prepare the ground for the migration from the preview2-prototyping repo to wasmtime. A table is being defined to simulate the future resource type. Additionally, it will simplify using Component Linker with the wasi-http module.

<details>
<summary>Usage example with WASI Preview2</summary>

use wasmtime::{
    component::{Component, Linker},
    Config, Engine, Store,
};
use wasmtime_wasi::preview2::{
    command::Command, Table, WasiCtx, WasiCtxBuilder, WasiView,
};
use wasmtime_wasi_http::{WasiHttpCtx, WasiHttpView};

pub struct Ctx {
   table: Table,
    wasi: WasiCtx,
    http: WasiHttpCtx,
}

impl WasiView for Ctx {
    fn table(&self) -> &Table {
        &self.table
    }
    fn table_mut(&mut self) -> &mut Table {
        &mut self.table
    }
    fn ctx(&self) -> &WasiCtx {
        &self.wasi
    }
    fn ctx_mut(&mut self) -> &mut WasiCtx {
        &mut self.wasi
    }
}

impl WasiHttpView for Ctx {
    fn http_ctx(&self) -> &WasiHttpCtx {
        &self.http
    }
    fn http_ctx_mut(&mut self) -> &mut WasiHttpCtx {
        &mut self.http
    }
}

#[tokio::main]
async fn main() -> anyhow::Result<()> {
    let wasi = WasiCtxBuilder::new().inherit_stdio().build();
    let http = WasiHttpCtx::new();
    let mut config = Config::new();
    config.wasm_backtrace_details(wasmtime::WasmBacktraceDetails::Enable);
    config.wasm_component_model(true);
    config.async_support(true);

    let engine = Engine::new(&config)?;
    let component = Component::from_file(&engine, "component.wasm")?;
    let mut store = Store::new(&engine, Ctx { table, wasi, http });
    let mut linker = Linker::new(&engine);

    add_to_linker(&mut linker)?;
    wasmtime_wasi_http::add_to_component_linker(&mut linker)?;

    let (wasi, _instance) =
        wasi::Command::instantiate_async(&mut store, &component, &linker).await?;
    let result = wasi
        .call_main(&mut store, &[])
        .await
        .map_err(|e| anyhow::anyhow!("wasm failed with {e:?}"))?
        .map_err(|e| anyhow::anyhow!("command returned with failing exit status {e:?}"))?;

    Ok(())
}

</details>

Depends on: https://github.com/bytecodealliance/wasmtime/pull/6836.

Wasmtime GitHub notifications bot (Aug 11 2023 at 01:57):

eduardomourar submitted PR review.

Wasmtime GitHub notifications bot (Aug 11 2023 at 01:57):

eduardomourar created PR review comment:

it will make more sense when using the preview2::WasiCtx as laid out in this pr. the wasmtime cli tests will be fixed then

Wasmtime GitHub notifications bot (Aug 11 2023 at 02:11):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 11 2023 at 03:54):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 11 2023 at 04:19):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 13 2023 at 14:56):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 13 2023 at 14:59):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 13 2023 at 16:17):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 14 2023 at 22:14):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 14 2023 at 22:14):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 14 2023 at 22:14):

pchickey created PR review comment:

    # Ensure wit definitions are in sync: both wasmtime-wasi and wasmtime-wasi-http need their own
    # copy of the wit definitions so publishing works, but we need to ensure they are identical copies.

Wasmtime GitHub notifications bot (Aug 16 2023 at 02:05):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 16 2023 at 02:08):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 16 2023 at 02:54):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 16 2023 at 23:32):

elliottt submitted PR review:

This is looking great! I just had two questions before we merge.

Wasmtime GitHub notifications bot (Aug 16 2023 at 23:32):

elliottt submitted PR review:

This is looking great! I just had two questions before we merge.

Wasmtime GitHub notifications bot (Aug 16 2023 at 23:32):

elliottt created PR review comment:

What do you think about renaming this module so that it's not colliding with a keyword? Maybe types.rs instead?

Wasmtime GitHub notifications bot (Aug 16 2023 at 23:32):

elliottt created PR review comment:

Does this need to be uncommented?

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:17):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:17):

pchickey created PR review comment:

Eduardo mentioned this on zulip - we are removing it as a module runtime option in the CLI for now, and will re-enable it as part of the component linker once streams & pollables are aligned with wasmtime-wasi, and https://github.com/bytecodealliance/wasmtime/pull/6836 lands.

The fix for now is to uncomment everything and bail on line 769 instead.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:18):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:18):

pchickey created PR review comment:

We really should do that, but I think it can be done in a follow up PR.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey created PR review comment:

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey created PR review comment:

        #[cfg(not(feature = "wasi-http"))]

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey created PR review comment:

        }

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey created PR review comment:

        {

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey created PR review comment:

        #[cfg(feature = "wasi-http")]

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey created PR review comment:

        bail!("wasi-http support will be swapped over to component CLI support soon");

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey created PR review comment:

        {

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey created PR review comment:

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey created PR review comment:

        }

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:20):

pchickey updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:21):

pchickey updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:21):

pchickey updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:21):

pchickey updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:21):

pchickey updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:21):

pchickey updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:21):

pchickey updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:22):

pchickey updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:22):

pchickey updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:23):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 17 2023 at 01:23):

pchickey has enabled auto merge for PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 10:18):

pchickey has disabled auto merge for PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 10:18):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 16:50):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 16:54):

pchickey has enabled auto merge for PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 17:29):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 18:51):

eduardomourar updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 20:58):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 21:43):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 22:27):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 22:41):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 22:46):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 22:53):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 23:09):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 17 2023 at 23:41):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 18 2023 at 00:16):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 18 2023 at 00:45):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 18 2023 at 01:16):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 18 2023 at 02:12):

elliottt updated PR #6195.

Wasmtime GitHub notifications bot (Aug 18 2023 at 02:12):

elliottt has enabled auto merge for PR #6195.

Wasmtime GitHub notifications bot (Aug 18 2023 at 03:34):

elliottt merged PR #6195.

Last updated: Nov 22 2024 at 17:03 UTC