Stream: git-wasmtime

Topic: wasmtime / PR #6182 doc: fix StackSlot reference to Funct...

Wasmtime GitHub notifications bot (Apr 08 2023 at 02:07):

chrisdickinson opened PR #6182 from chrisdickinson:chris/20230407-fix-create-stack-slot-link-5838 to bytecodealliance:main:

FunctionBuilder::create_stackslot was renamed create_sized_stack_slot, this updates the link in the StackBuilder docstring.

Fixes #5838.

Wasmtime GitHub notifications bot (Apr 08 2023 at 02:07):

chrisdickinson requested elliottt for a review on PR #6182.

Wasmtime GitHub notifications bot (Apr 08 2023 at 02:07):

chrisdickinson requested wasmtime-compiler-reviewers for a review on PR #6182.

Wasmtime GitHub notifications bot (Apr 09 2023 at 19:56):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Apr 09 2023 at 19:56):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Apr 09 2023 at 19:56):

cfallin created PR review comment:

Can we mention create_dynamic_stack_slot here too? (Both this and the sized variant are peers -- both are valid ways to create stackslots, for different sorts of types.)

Wasmtime GitHub notifications bot (Apr 09 2023 at 20:47):

chrisdickinson updated PR #6182.

Wasmtime GitHub notifications bot (Apr 09 2023 at 20:48):

chrisdickinson submitted PR review.

Wasmtime GitHub notifications bot (Apr 09 2023 at 20:48):

chrisdickinson created PR review comment:

Sure! Thanks for the heads up. I've re-pushed the commit with the requested changes.

Wasmtime GitHub notifications bot (Apr 09 2023 at 21:14):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Apr 09 2023 at 22:35):

cfallin merged PR #6182.

Last updated: Dec 23 2024 at 13:07 UTC