Stream: git-wasmtime

Topic: wasmtime / PR #6178 Make cranelift-interpreter non-generi...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 17:03):

bjorn3 opened PR #6178 from bjorn3:bsc-unwinding-interpreter-non-generic to bytecodealliance:main:

Fixes #5793

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 17:03):

bjorn3 requested fitzgen for a review on PR #6178.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 17:03):

bjorn3 requested wasmtime-compiler-reviewers for a review on PR #6178.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 17:05):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 17:05):

bjorn3 created PR review comment:

Left this as extension trait to make this PR smaller. We can always move methods to DataValue directly or inline them at the call site in cranelift-interpreter in the future.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 17:06):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 17:06):

bjorn3 created PR review comment:

These needed conflicted with PartialEq/PartialOrd impls of DataValue causing ambiguity during method resolution. I took the opportunity to inline them all.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 17:06):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 17:06):

bjorn3 created PR review comment:

This method directly forwards to the equivalent method on DataValue.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 17:06):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 17:06):

bjorn3 created PR review comment:

This method directly forwards to the equivalent method on DataValue.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 19:57):

afonso360 requested afonso360 for a review on PR #6178.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 19:58):

afonso360 assigned PR #6178 to afonso360.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 20:52):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 20:52):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 20:52):

jameysharp created PR review comment:

This can be just !=, can't it?

                IntCC::NotEqual => left != right,

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 21:55):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 21:58):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 22:44):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 22:44):

bjorn3 created PR review comment:

Right, I was considering that for floats it isn't equal, but thise can't occur here.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 22:45):

bjorn3 edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 22:45):

bjorn3 updated PR #6178 (assigned to afonso360).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 09:51):

bjorn3 requested wasmtime-fuzz-reviewers for a review on PR #6178.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 09:51):

bjorn3 updated PR #6178 (assigned to afonso360).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 10:55):

bjorn3 updated PR #6178 (assigned to afonso360).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 11:02):

afonso360 has enabled auto merge for PR #6178.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 11:49):

afonso360 merged PR #6178.

Last updated: Nov 22 2024 at 17:03 UTC