Stream: git-wasmtime

Topic: wasmtime / PR #6175 Removes debug assertion that was rela...

Wasmtime GitHub notifications bot (Apr 07 2023 at 13:34):

kevaundray opened PR #6175 from kevaundray:kw/patch-rem-796 to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

The comment states that when 796 is fixed, that the debug assertion can be removed.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 07 2023 at 13:34):

kevaundray requested fitzgen for a review on PR #6175.

Wasmtime GitHub notifications bot (Apr 07 2023 at 13:34):

kevaundray requested wasmtime-compiler-reviewers for a review on PR #6175.

Wasmtime GitHub notifications bot (Apr 10 2023 at 22:39):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Apr 10 2023 at 22:39):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Apr 10 2023 at 22:39):

jameysharp created PR review comment:

I'd prefer not to have an unrelated change in this PR, and particularly not one that just changes spelling from British English to American English. Let's leave the Commonwealth folks alone. :laughing:

Wasmtime GitHub notifications bot (Apr 11 2023 at 10:18):

kevaundray updated PR #6175.

Wasmtime GitHub notifications bot (Apr 11 2023 at 10:18):

kevaundray submitted PR review.

Wasmtime GitHub notifications bot (Apr 11 2023 at 10:18):

kevaundray created PR review comment:

Done!

Wasmtime GitHub notifications bot (Apr 11 2023 at 16:52):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Apr 11 2023 at 17:30):

jameysharp merged PR #6175.

Last updated: Oct 23 2024 at 20:03 UTC