Stream: git-wasmtime

Topic: wasmtime / PR #6172 Allow serializing all cranelift-modul...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 10:40):

bjorn3 opened PR #6172 from bjorn3:bsc-unwinding-module-serialize2 to bytecodealliance:main:

This allows a Module implementation to serialize it's internal state and deserialize it in another compilation session. For example to implement LTO or to load the module into cranelift-interpreter.

This is the last PR in the series for now. The actual implementation of a module that can be serialized is in cg_clif. I may extract it in the future, but for now these are almost all the changes that need to be made on the cranelift side. The previous PR's in this series are https://github.com/bytecodealliance/wasmtime/pull/6169 and https://github.com/bytecodealliance/wasmtime/pull/6170.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 10:40):

bjorn3 requested fitzgen for a review on PR #6172.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 10:40):

bjorn3 requested wasmtime-compiler-reviewers for a review on PR #6172.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 10:40):

bjorn3 requested wasmtime-default-reviewers for a review on PR #6172.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 10:42):

bjorn3 updated PR #6172.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 11:14):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 11:14):

bjorn3 created PR review comment:

The Deserialize impl is based on serde-derive's macro expansion, but it has been cleaned up a lot and modified to run get_names instead of expecting a names field. This should be license technically, right?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 19:23):

fitzgen requested bnjbvr for a review on PR #6172.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 17:41):

bjorn3 updated PR #6172.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 19:36):

bnjbvr submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 19:36):

bnjbvr submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 19:36):

bnjbvr created PR review comment:

Any chance you can use one of the facilities provided by serde, e.g. #[serde(serialize_with = ...)] on the names field, instead?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 19:36):

bnjbvr created PR review comment:

nit: can you use expect for something a bit shorter here?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 22:13):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 22:13):

bjorn3 created PR review comment:

When applied to the names field that doesn't give access to the functions and data_objects fields to reconstruct the names field from from what I can tell.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 14:11):

bjorn3 updated PR #6172.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 14:11):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 14:11):

bjorn3 created PR review comment:

Done

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 14:29):

bjorn3 updated PR #6172.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2023 at 10:43):

bjorn3 updated PR #6172.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2023 at 12:38):

bnjbvr submitted PR review:

Lgtm!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2023 at 13:19):

bnjbvr merged PR #6172.

Last updated: Oct 23 2024 at 20:03 UTC