sunfishcode opened PR #6171 from sunfishcode:sunfishcode/update-rustix
to bytecodealliance:main
:
This updates to rustix 0.37.7, which contains some features we can use to implement more features in wasi-common for the wasi-sockets API. This also pulls in several other updates to avoid having multiple versions of rustix.
This does introduce multiple versions of windows-sys, as the errno and tokio crates are currently using 0.45 while rustix and other dependencies have updated to 0.48; PRs updating these are already in flight so this will hopefully be resolved soon.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
sunfishcode requested alexcrichton for a review on PR #6171.
sunfishcode requested wasmtime-core-reviewers for a review on PR #6171.
sunfishcode requested wasmtime-default-reviewers for a review on PR #6171.
alexcrichton submitted PR review.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
Would it be ok to add an audit for 133 -> 141? I'd hope that libc updates are at least pretty minor
sunfishcode submitted PR review.
sunfishcode created PR review comment:
It's just (checks) 13 thousand lines of diff... :upside_down_face: . I'll look through it and see if I can come up with something meaningful to say for an audit.
sunfishcode updated PR #6171.
sunfishcode submitted PR review.
sunfishcode created PR review comment:
Ok, I've now looked through the diff and added an audit. Many of those lines are for platforms Wasmtime doesn't support.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
Ah ok I didn't realize that the diff would be so large, but your vet makes sense to me.
sunfishcode updated PR #6171.
sunfishcode updated PR #6171.
sunfishcode requested fitzgen for a review on PR #6171.
sunfishcode requested wasmtime-compiler-reviewers for a review on PR #6171.
sunfishcode updated PR #6171.
sunfishcode updated PR #6171.
sunfishcode updated PR #6171.
sunfishcode updated PR #6171.
sunfishcode updated PR #6171.
sunfishcode updated PR #6171.
sunfishcode updated PR #6171.
sunfishcode merged PR #6171.
Last updated: Dec 23 2024 at 12:05 UTC