Stream: git-wasmtime

Topic: wasmtime / PR #6163 Allow WASI to open directories withou...

Wasmtime GitHub notifications bot (Apr 06 2023 at 01:09):

jameysharp opened PR #6163 from jameysharp:wasi-open to bytecodealliance:main:

This is an initial proof-of-concept alternative to #4967, which was an alternative to #4947. Unlike the other two attempts, this one should be race-free. I'm not particularly happy with it yet though, just opening this PR for discussion.

Open issues:

• I don't understand how the capabilities are supposed to work yet. Opening a directory got file_caps from fs_rights_inheriting, while opening a file got them from fs_rights_base. I haven't implemented that distinction in this PR yet.

To-do:

• Pull in the other useful bits from the other two PRs, like test cases
• Remove WasiDir::open_dir and related bits, which is now used only in tests.

Wasmtime GitHub notifications bot (Apr 06 2023 at 01:09):

jameysharp requested pchickey for a review on PR #6163.

Wasmtime GitHub notifications bot (Apr 06 2023 at 01:09):

jameysharp requested sunfishcode for a review on PR #6163.

Wasmtime GitHub notifications bot (Apr 15 2023 at 00:21):

jameysharp updated PR #6163.

Wasmtime GitHub notifications bot (Apr 18 2023 at 00:08):

jameysharp updated PR #6163.

Wasmtime GitHub notifications bot (Apr 18 2023 at 00:42):

jameysharp updated PR #6163.

Wasmtime GitHub notifications bot (Apr 18 2023 at 19:10):

jameysharp updated PR #6163.

Wasmtime GitHub notifications bot (Apr 18 2023 at 19:45):

jameysharp has marked PR #6163 as ready for review.

Wasmtime GitHub notifications bot (Apr 18 2023 at 19:45):

jameysharp requested wasmtime-core-reviewers for a review on PR #6163.

Wasmtime GitHub notifications bot (Apr 21 2023 at 16:55):

pchickey submitted PR review:

Sorry this took a while for me to properly review. This is good work, thank you.

Wasmtime GitHub notifications bot (Apr 21 2023 at 17:33):

pchickey merged PR #6163.

Last updated: Oct 23 2024 at 20:03 UTC