wasmtime / PR #6161 Some improvements to the wasi-http cl... · git-wasmtime

since Response is defined above, I would move this function up there. A more idiomatic way to write it is, right under the definition of struct Response, impl Response { fn header(&self, name: &str) -> Option<&String> { self.headers.iter().find_map(|(k, v)| if k == name { Some(v) } else { None } ) }

Wasmtime GitHub notifications bot (Apr 10 2023 at 21:15):

pchickey created PR review comment:

This is going to break as soon as we run more than one test in a process, which I hope we will do soon. I'll work on the structural changes to the test suite to work that out soon, but its ok for now

Wasmtime GitHub notifications bot (Apr 11 2023 at 00:33):

brendandburns updated PR #6161.

Wasmtime GitHub notifications bot (Apr 11 2023 at 00:50):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Apr 11 2023 at 00:50):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Apr 11 2023 at 00:50):

pchickey created PR review comment:

Tests are the one place in Rust I prefer to write code that panics on failure - after all, that is what assert_eq! is doing. So in this case I would write this as let method = r1.header("x-wasmtime-test-method").unwrap(); rather than mess around with having the alternative value around with the correct type, which is clunky.

Wasmtime GitHub notifications bot (Apr 11 2023 at 03:56):

pchickey merged PR #6161.

Wasmtime GitHub notifications bot (Apr 12 2023 at 02:26):

brendandburns created PR review comment:

Thanks, I'm still learning idiomatic rust. I will correct this in a follow-on PR.

Wasmtime GitHub notifications bot (Apr 12 2023 at 02:26):

brendandburns submitted PR review.

Last updated: Oct 23 2024 at 20:03 UTC