Stream: git-wasmtime

Topic: wasmtime / PR #6161 Some improvements to the wasi-http cl...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 22:39):

brendandburns opened PR #6161 from brendandburns:wasi_http_next to bytecodealliance:main:

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 22:39):

brendandburns requested wasmtime-core-reviewers for a review on PR #6161.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 22:39):

brendandburns requested pchickey for a review on PR #6161.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 22:42):

brendandburns updated PR #6161.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 22:46):

brendandburns updated PR #6161.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 21:17):

brendandburns requested wasmtime-default-reviewers for a review on PR #6161.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 21:17):

brendandburns updated PR #6161.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 07 2023 at 21:19):

brendandburns updated PR #6161.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 21:15):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 21:15):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 21:15):

pchickey created PR review comment:

since Response is defined above, I would move this function up there. A more idiomatic way to write it is, right under the definition of struct Response, impl Response { fn header(&self, name: &str) -> Option<&String> { self.headers.iter().find_map(|(k, v)| if k == name { Some(v) } else { None } ) }

view this post on Zulip Wasmtime GitHub notifications bot (Apr 10 2023 at 21:15):

pchickey created PR review comment:

This is going to break as soon as we run more than one test in a process, which I hope we will do soon. I'll work on the structural changes to the test suite to work that out soon, but its ok for now

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 00:33):

brendandburns updated PR #6161.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 00:50):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 00:50):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 00:50):

pchickey created PR review comment:

Tests are the one place in Rust I prefer to write code that panics on failure - after all, that is what assert_eq! is doing. So in this case I would write this as let method = r1.header("x-wasmtime-test-method").unwrap(); rather than mess around with having the alternative value around with the correct type, which is clunky.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 11 2023 at 03:56):

pchickey merged PR #6161.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 02:26):

brendandburns created PR review comment:

Thanks, I'm still learning idiomatic rust. I will correct this in a follow-on PR.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 12 2023 at 02:26):

brendandburns submitted PR review.


Last updated: Dec 23 2024 at 12:05 UTC