Stream: git-wasmtime

Topic: wasmtime / PR #6160 Add `only_interfaces` and `with` to t...

Wasmtime GitHub notifications bot (Apr 05 2023 at 22:23):

elliottt opened PR #6160 from elliottt:trevor/bindgen-only-interfaces to bytecodealliance:main:

Add the only_interfaces and with options to the bindgen! macro. These two
additional options enable the definitions of a use of bindgen! to be split up
and reused in the following way:

• Passing only_interfaces: true to an invocation of bindgen! will cause only
  the interfaces depended on by the supplied world to be generated, allowing the
  interface definitions depended on by two world files to be shared.

• Passing with: { "a": module::name } allows references to the a import to
  be remapped to a known module, in this case module::name. When this option
  is supplied, no code will be generated for the interface a, assuming that
  those definitions came from a previous use of bindgen! with
  only_interfaces: true.

TODO:

• [ ] Add tests

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 05 2023 at 22:24):

elliottt requested pchickey for a review on PR #6160.

Wasmtime GitHub notifications bot (Apr 05 2023 at 22:24):

elliottt requested alexcrichton for a review on PR #6160.

Wasmtime GitHub notifications bot (Apr 05 2023 at 22:24):

elliottt edited PR #6160:

Add the only_interfaces and with options to the bindgen! macro. These two
additional options enable the definitions of a use of bindgen! to be split up
and reused in the following way:

• Passing only_interfaces: true to an invocation of bindgen! will cause only
  the interfaces depended on by the supplied world to be generated, allowing the
  interface definitions depended on by two world files to be shared.

• Passing with: { "a": module::name } allows references to the a import to
  be remapped to a known module, in this case module::name. When this option
  is supplied, no code will be generated for the interface a, assuming that
  those definitions came from a previous use of bindgen! with
  only_interfaces: true.

TODO:

• [ ] Add tests to assert the output of the bindgen! macro using these new options

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 05 2023 at 22:30):

elliottt edited PR #6160:

Add the only_interfaces and with options to the bindgen! macro. These two additional options enable the definitions of a use of bindgen! to be split up and reused in the following way:

• Passing only_interfaces: true to an invocation of bindgen! will cause only the interfaces depended on by the supplied world to be generated, allowing the interface definitions depended on by two world files to be shared.
• Passing with: { "a": module::name } allows references to the a import to be remapped to a known module, in this case module::name. When this option is supplied, no code will be generated for the interface a, assuming that those definitions came from a previous use of bindgen! with only_interfaces: true.

Here's a use in the preview2-prototyping repository for a motivating example of how this can be used with the command world.

TODO:

• [ ] Add tests to assert the output of the bindgen! macro using these new options

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 05 2023 at 23:07):

elliottt updated PR #6160.

Wasmtime GitHub notifications bot (Apr 05 2023 at 23:07):

elliottt edited PR #6160:

Add the only_interfaces and with options to the bindgen! macro. These two additional options enable the definitions of a use of bindgen! to be split up and reused in the following way:

• Passing only_interfaces: true to an invocation of bindgen! will cause only the interfaces depended on by the supplied world to be generated, allowing the interface definitions depended on by two world files to be shared.
• Passing with: { "a": module::name } allows references to the a import to be remapped to a known module, in this case module::name. When this option is supplied, no code will be generated for the interface a, assuming that those definitions came from a previous use of bindgen! with only_interfaces: true.

Here's a use in the preview2-prototyping repository for a motivating example of how this can be used with the command world.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Apr 05 2023 at 23:08):

elliottt has marked PR #6160 as ready for review.

Wasmtime GitHub notifications bot (Apr 05 2023 at 23:08):

elliottt requested wasmtime-core-reviewers for a review on PR #6160.

Wasmtime GitHub notifications bot (Apr 10 2023 at 14:42):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 10 2023 at 14:42):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Apr 10 2023 at 14:42):

alexcrichton created PR review comment:

Perhaps opts.with.extend(val)?

Wasmtime GitHub notifications bot (Apr 10 2023 at 22:25):

elliottt updated PR #6160.

Wasmtime GitHub notifications bot (Apr 10 2023 at 22:29):

elliottt created PR review comment:

Yeah, that's much better :)

Wasmtime GitHub notifications bot (Apr 10 2023 at 22:29):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Apr 10 2023 at 22:31):

elliottt updated PR #6160.

Wasmtime GitHub notifications bot (Apr 10 2023 at 22:54):

elliottt updated PR #6160.

Wasmtime GitHub notifications bot (Apr 11 2023 at 00:08):

elliottt merged PR #6160.

Last updated: Dec 23 2024 at 13:07 UTC