Stream: git-wasmtime

Topic: wasmtime / PR #6147 Use an unaligned write for resolving ...


view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 15:05):

alexcrichton opened PR #6147 from alexcrichton:unaligned-write to bytecodealliance:main:

This commit changes resolution of libcall relocations from writing a usize into a raw pointer to specifically performing an unaligned write. The addresses of libcalls to write to are not guaranteed to be aligned, so this could technically have caused issues on some platforms perhaps.

This was discovered now that Rust nightly will panic on unaligned writes to pointers, and fuzzing ran into this case when compiled with a more recent Nightly build.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 15:05):

alexcrichton requested fitzgen for a review on PR #6147.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 15:05):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6147.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 15:27):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 15:28):

fitzgen has enabled auto merge for PR #6147.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 05 2023 at 15:57):

fitzgen merged PR #6147.


Last updated: Dec 23 2024 at 12:05 UTC