Stream: git-wasmtime

Topic: wasmtime / PR #6138 Derive `Copy` on `wasmtime::ValType`

Wasmtime GitHub notifications bot (Apr 03 2023 at 22:57):

jbourassa opened PR #6138 from jbourassa:valtype-copy to bytecodealliance:main:

ValType is small enough that it can be copiable. By making ValType Copy, Copy structs can have ValType fields in them.

The need for this came up in bytecodealliance/wasmtime-rb#158. By making ValType Copy, we could get rid of this workaround.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Apr 03 2023 at 22:57):

jbourassa requested pchickey for a review on PR #6138.

Wasmtime GitHub notifications bot (Apr 03 2023 at 22:57):

jbourassa requested wasmtime-core-reviewers for a review on PR #6138.

Wasmtime GitHub notifications bot (Apr 04 2023 at 16:48):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Apr 04 2023 at 17:21):

pchickey merged PR #6138.

Last updated: Nov 22 2024 at 17:03 UTC