Wasmtime GitHub notifications bot (Apr 03 2023 at 17:23): Wasmtime GitHub notifications bot (Apr 03 2023 at 17:23):pchickey opened PR #6136 from bytecodealliance:pch/cargo_deny_add_licenses to bytecodealliance:main:
These are required in order to merge https://github.com/bytecodealliance/wasmtime/pull/5929.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 03 2023 at 17:23):pchickey requested elliottt for a review on PR #6136.
Wasmtime GitHub notifications bot (Apr 03 2023 at 17:23):pchickey requested wasmtime-default-reviewers for a review on PR #6136.
Wasmtime GitHub notifications bot (Apr 03 2023 at 17:23):pchickey requested tschneidereit for a review on PR #6136.
Wasmtime GitHub notifications bot (Apr 03 2023 at 17:23):pchickey requested wasmtime-default-reviewers for a review on PR #6136.
Wasmtime GitHub notifications bot (Apr 03 2023 at 17:23):pchickey requested fitzgen for a review on PR #6136.
Wasmtime GitHub notifications bot (Apr 03 2023 at 17:32):pchickey edited PR #6136:
These are required in order to merge https://github.com/bytecodealliance/wasmtime/pull/5929.
I discussed this change with Till: we believe that these licenses are compatible with Wasmtime's license and don't add any fundamentally new requirements to the existing allow-list.
In an ideal world, I could imagine making an RFC or asking the Bytecode Alliance board weigh in on this decision, but we don't have any process or guidance for how to go about changing this list, and we don't expect this change to be controversial in any way. So, I've asked all of the BA TSC members (@fitzgen @tschneidereit @ricochet) to please approve this PR before I merge it.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Apr 03 2023 at 17:36):rvolosatovs submitted PR review.
Wasmtime GitHub notifications bot (Apr 03 2023 at 17:36):rvolosatovs created PR review comment:
Why is OpenSSL license still necessary if https://github.com/bytecodealliance/wasmtime/pull/5929#issuecomment-1492628300 has switched to
rustls?
Wasmtime GitHub notifications bot (Apr 03 2023 at 17:38):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Apr 03 2023 at 17:38):pchickey created PR review comment:
Yes, because the
ringcrate includes the OpenSSL license in its LICENSE file.
Wasmtime GitHub notifications bot (Apr 03 2023 at 17:39):rvolosatovs submitted PR review.
Wasmtime GitHub notifications bot (Apr 03 2023 at 19:34):tschneidereit submitted PR review.
Wasmtime GitHub notifications bot (Apr 03 2023 at 19:41):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Apr 03 2023 at 21:03):pchickey updated PR #6136.
Wasmtime GitHub notifications bot (Apr 03 2023 at 21:41):ricochet submitted PR review.
Wasmtime GitHub notifications bot (Apr 03 2023 at 22:43):pchickey merged PR #6136.
Last updated: Dec 23 2024 at 12:05 UTC