Stream: git-wasmtime

Topic: wasmtime / PR #6131 Make cranelift-codegen actually no_st...

Wasmtime GitHub notifications bot (Apr 01 2023 at 01:20):

ondra05 opened PR #6131 from ondra05:main to bytecodealliance:main:

cranelift-codegen has an optional feature std, but when not enabled, it fails to compile demanding std.

Most of the issues were an easy fix:

1. Which was on several places used instead of core / alloc (fixed using simple search-replace)
2. Replacing std's HashMap in scoped_hash_map with hashbrown's (added little shim)

Currently the only remaining fix is timing module which relies on thread locals which in current implementation state are in std and std::time::Instant.

Here I am not so sure about possible fix. The thread local issue could be worked around by using nightly thread locals implementation, which isn't std dependent if std feature not used. The missing Instant could be fixed by not having a default timer implementation for no-std / having a no-op one. Both can be fixed by having no-op timer functions under conditional compilation, but that doesn't sound like a particularly nice solution.

Wasmtime GitHub notifications bot (May 06 2023 at 11:10):

ondra05 closed without merge PR #6131.

Last updated: Nov 22 2024 at 16:03 UTC