Stream: git-wasmtime

Topic: wasmtime / PR #6130 ISLE: rewrite loose inequalities to s...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 15:22):

Kmeakin opened PR #6130 from Kmeakin:icmp-loose-inequalities-to-strict-inequalities to bytecodealliance:main:

Rewrites loose inequalities against constants to equivalent strict inequalities. By itself not more efficient, but should expose more CSE opportunities (eg ule x, 2 && ult x, 1)

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 15:22):

Kmeakin requested cfallin for a review on PR #6130.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 15:22):

Kmeakin requested wasmtime-compiler-reviewers for a review on PR #6130.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 17:31):

Kmeakin edited PR #6130:

Rewrites loose inequalities against constants to equivalent strict inequalities, and strict inequalities to equalities when possible. By itself not more efficient, but should expose more CSE opportunities (eg ule x, 2 && ult x, 1)

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 17:32):

Kmeakin edited PR #6130:

Rewrites loose inequalities against constants to equivalent strict inequalities, and strict inequalities to equalities when possible. By itself not more efficient, but should expose more CSE opportunities (eg ule x, 2 && ult x, 1)

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 17:34):

Kmeakin updated PR #6130.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 17:45):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 17:45):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 17:45):

cfallin created PR review comment:

It might be nice to have "checked-add" and "checked-sub" constructors (we may already?) so that one could write

(if-let c_plus_1 (u64_checked_add_ty cty c 1))

what do you think?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 18:01):

Kmeakin created PR review comment:

I think I prefer the current version

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 18:01):

Kmeakin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 01 2023 at 16:32):

Kmeakin updated PR #6130.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 01 2023 at 16:33):

Kmeakin updated PR #6130.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 01 2023 at 16:35):

Kmeakin updated PR #6130.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 01 2023 at 16:35):

Kmeakin requested cfallin for a review on PR #6130.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2023 at 17:42):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 04 2023 at 18:18):

cfallin merged PR #6130.


Last updated: Dec 23 2024 at 12:05 UTC