Stream: git-wasmtime

Topic: wasmtime / PR #6123 Specify a `read` parameter for `ISLE`...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 05:20):

yuyang-ok opened PR #6123 from yuyang-ok:fix_col to bytecodealliance:main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 05:20):

yuyang-ok requested jameysharp for a review on PR #6123.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 05:20):

yuyang-ok requested wasmtime-compiler-reviewers for a review on PR #6123.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 05:27):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 05:27):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 05:27):

cfallin created PR review comment:

Rather than the callback approach, maybe it would be simpler to just provide a list of paths and strings? Something like:

pub fn from_file_contents(files: Vec<(PathBuf, String)>) -> Result<Lexer<'a>> ?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 05:29):

yuyang-ok closed without merge PR #6123.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 05:30):

yuyang-ok reopened PR #6123.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 05:58):

yuyang-ok edited PR #6123.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 05:59):

yuyang-ok submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 05:59):

yuyang-ok created PR review comment:

@cfallin Yeah,sure.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2023 at 21:11):

yuyang-ok updated PR #6123.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2023 at 22:01):

yuyang-ok updated PR #6123.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 21 2023 at 22:18):

yuyang-ok updated PR #6123.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2023 at 16:11):

jameysharp submitted PR review:

All the logic is good here, and I can see why this is useful, so I'll go ahead and merge it. Thank you!

For future reference: I would have preferred that you not delete the blank lines that are in places outside of your changes, but I don't care enough to delay this PR.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 24 2023 at 17:32):

jameysharp merged PR #6123.

Last updated: Nov 22 2024 at 16:03 UTC