Stream: git-wasmtime

Topic: wasmtime / PR #6120 ISLE: move `icmp` rewrites to separat...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 23:48):

Kmeakin opened PR #6120 from icmp-rewrites-separate-file to main:

Move icmp-related rewrite rules from algebraic.isle to icmp.isle.
Also move icmp-related tests from algebraic.clif to icmp.clif.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 23:48):

Kmeakin requested elliottt for a review on PR #6120.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 23:48):

Kmeakin requested wasmtime-compiler-reviewers for a review on PR #6120.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 00:01):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 00:01):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 00:01):

cfallin created PR review comment:

It looks like these rules (for reflexive/irreflexive comparisons) are new; would you mind putting them in a separate PR, just to keep the logical changes separated?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 00:13):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 00:13):

jameysharp created PR review comment:

Looks like they aren't new but they are refactored. I agree with Chris that I'd rather discuss those changes in a separate PR, as I would rather not refactor them in quite this way. If you can move the rules verbatim this PR will be easier to review and get merged.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 00:19):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 00:19):

jameysharp created PR review comment:

Let's not put unparameterized tests in script-generated tests. I think these two tests should either stay in algebraic.clif or go into a new file.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 00:32):

Kmeakin updated PR #6120 from icmp-rewrites-separate-file to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 00:45):

Kmeakin requested jameysharp for a review on PR #6120.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 00:45):

Kmeakin requested cfallin for a review on PR #6120.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 16:41):

Kmeakin updated PR #6120.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2023 at 17:13):

Kmeakin updated PR #6120.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 17:40):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2023 at 18:21):

cfallin merged PR #6120.

Last updated: Oct 23 2024 at 20:03 UTC