rvolosatovs opened PR #6117 from feat/unsized-host
to main
:
This allows to use implementations as trait objects (e.g.
Box<dyn myiface::Host>
)<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[x] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
alexcrichton submitted PR review.
alexcrichton created PR review comment:
Mind deleting the
:
in the trait definition here while you're at it as it's no longer necessary?
alexcrichton submitted PR review.
rvolosatovs submitted PR review.
rvolosatovs created PR review comment:
Sure
rvolosatovs updated PR #6117 from feat/unsized-host
to main
.
rvolosatovs has marked PR #6117 as ready for review.
rvolosatovs requested pchickey for a review on PR #6117.
rvolosatovs requested wasmtime-core-reviewers for a review on PR #6117.
alexcrichton has enabled auto merge for PR #6117.
alexcrichton requested alexcrichton for a review on PR #6117.
alexcrichton merged PR #6117.
Last updated: Dec 23 2024 at 12:05 UTC