Stream: git-wasmtime

Topic: wasmtime / PR #6117 feat(wit-bindgen): relax `Sized` boun...

Wasmtime GitHub notifications bot (Mar 29 2023 at 16:59):

rvolosatovs opened PR #6117 from feat/unsized-host to main:

This allows to use implementations as trait objects (e.g. Box<dyn myiface::Host>)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [x] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 29 2023 at 17:46):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 29 2023 at 17:46):

alexcrichton created PR review comment:

Mind deleting the : in the trait definition here while you're at it as it's no longer necessary?

Wasmtime GitHub notifications bot (Mar 29 2023 at 17:46):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 29 2023 at 17:47):

rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Mar 29 2023 at 17:47):

rvolosatovs created PR review comment:

Sure

Wasmtime GitHub notifications bot (Mar 29 2023 at 18:07):

rvolosatovs updated PR #6117 from feat/unsized-host to main.

Wasmtime GitHub notifications bot (Mar 29 2023 at 18:07):

rvolosatovs has marked PR #6117 as ready for review.

Wasmtime GitHub notifications bot (Mar 29 2023 at 18:07):

rvolosatovs requested pchickey for a review on PR #6117.

Wasmtime GitHub notifications bot (Mar 29 2023 at 18:07):

rvolosatovs requested wasmtime-core-reviewers for a review on PR #6117.

Wasmtime GitHub notifications bot (Mar 29 2023 at 18:23):

alexcrichton has enabled auto merge for PR #6117.

Wasmtime GitHub notifications bot (Mar 29 2023 at 18:24):

alexcrichton requested alexcrichton for a review on PR #6117.

Wasmtime GitHub notifications bot (Mar 29 2023 at 19:00):

alexcrichton merged PR #6117.

Last updated: Nov 22 2024 at 16:03 UTC