Stream: git-wasmtime

Topic: wasmtime / PR #6113 x64: Deduplicate fcmp emission logic

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2023 at 20:17):

alexcrichton opened PR #6113 from deduplicate-emit-fcmp to main:

The select-of-fcmp lowering duplicated a good deal of FloatCC
lowering logic that was already done by emit_fcmp, so this commit
refactors these lowering rules to instead delegate to emit_fcmp and
then handle that result.

I also split up the commits here where the first one is slightly unidiomatic in a few places but doesn't affect any of the test outputs. The next two commits swap the order of a few operands and shows the test updates necessary to get there.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2023 at 20:17):

alexcrichton requested cfallin for a review on PR #6113.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2023 at 20:17):

alexcrichton requested elliottt for a review on PR #6113.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2023 at 20:17):

alexcrichton requested fitzgen for a review on PR #6113.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2023 at 20:17):

alexcrichton requested jameysharp for a review on PR #6113.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 00:19):

cfallin assigned PR #6113 to cfallin.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 00:22):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 00:22):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 00:22):

cfallin created PR review comment:

Pre-existing, but I think something is out-of-order in the pretty-printing here -- would you mind fixing this while we're here?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 15:06):

alexcrichton requested elliottt for a review on PR #6113.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 15:06):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6113.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 15:06):

alexcrichton updated PR #6113 (assigned to cfallin) from deduplicate-emit-fcmp to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 15:06):

alexcrichton has enabled auto merge for PR #6113.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 29 2023 at 17:30):

alexcrichton merged PR #6113.

Last updated: Dec 23 2024 at 12:05 UTC