Stream: git-wasmtime

Topic: wasmtime / PR #6111 Add `precise_output` argument to `tes...

Wasmtime GitHub notifications bot (Mar 28 2023 at 01:04):

Kmeakin opened PR #6111 from test-optimize-bless to main:

Allow test optimize tests to take the precise-output argument, and to be updated by CRANELIFT_TEST_BLESS, similar to test compile

Wasmtime GitHub notifications bot (Mar 28 2023 at 18:08):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 28 2023 at 18:08):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 28 2023 at 18:08):

jameysharp created PR review comment:

Since actual is only used in precise-output mode, allocating it can happen inside the if, right?

        if self.precise_output {
            let actual: Vec<_> = clif.lines().collect();
            check_precise_output(&actual, context)

Wasmtime GitHub notifications bot (Mar 28 2023 at 20:18):

Kmeakin requested cfallin for a review on PR #6111.

Wasmtime GitHub notifications bot (Mar 28 2023 at 20:18):

Kmeakin updated PR #6111 from test-optimize-bless to main.

Wasmtime GitHub notifications bot (Mar 28 2023 at 20:18):

Kmeakin requested elliottt for a review on PR #6111.

Wasmtime GitHub notifications bot (Mar 28 2023 at 20:18):

Kmeakin requested fitzgen for a review on PR #6111.

Wasmtime GitHub notifications bot (Mar 28 2023 at 20:47):

Kmeakin updated PR #6111 from test-optimize-bless to main.

Wasmtime GitHub notifications bot (Mar 28 2023 at 20:49):

Kmeakin updated PR #6111 from test-optimize-bless to main.

Wasmtime GitHub notifications bot (Mar 28 2023 at 22:31):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 28 2023 at 23:06):

jameysharp merged PR #6111.

Last updated: Oct 23 2024 at 20:03 UTC