Stream: git-wasmtime

Topic: wasmtime / PR #6108 Fix export translation for components.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2023 at 22:30):

peterhuene opened PR #6108 from fix-translation to main:

Exports in the component model cause a new index to be added to the index space of the item being exported.

This commit updates component translation so that translation of component export sections properly updates internal lists representing those index spaces.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2023 at 22:30):

peterhuene requested alexcrichton for a review on PR #6108.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2023 at 22:30):

peterhuene submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2023 at 22:30):

peterhuene created PR review comment:

@alexcrichton What should we do here?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2023 at 22:45):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2023 at 22:45):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 27 2023 at 22:45):

alexcrichton created PR review comment:

I think this entry can be ignored since we don't track the type information about modules here in this pass. For example translation of Payload::ModuleSection doesn't do anything to various index spaces.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2023 at 00:01):

peterhuene updated PR #6108 from fix-translation to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2023 at 00:01):

peterhuene has enabled auto merge for PR #6108.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2023 at 00:53):

peterhuene merged PR #6108.

Last updated: Oct 23 2024 at 20:03 UTC