Wasmtime GitHub notifications bot (Mar 22 2023 at 01:26): Wasmtime GitHub notifications bot (Mar 22 2023 at 01:26):jameysharp opened PR #6084 from codeowners to main:
We want to make sure every contributor gets some kind of meaningful response in a timely fashion. To that end, this PR configures GitHub to auto-assign somebody to every newly-opened PR.
People must only be added to this file if they've agreed to this obligation. The details of what's expected are listed in the file. I'll only merge this if it's signed off by everyone listed in this initial version.
I've requested review from everyone; please either approve or request to be removed. Or suggest changes, of course; I'd particularly like to know if my description of the expectations aren't clear or don't seem right, or if we should slice up the repository differently.
I considered using the bytecodealliance/cranelift-core and wasmtime-core teams for this, but they have too many people and I wanted to make sure I was getting opt-in from everyone. Eventually I think we should create a few new teams specifically for this purpose, but that requires bytecodealliance org admin rights as far as I can tell, and I wanted to get the general shape of this sorted out before dealing with that.
I'd like to ask some more people to join some of these lists, but for example @itsrainy is out this week so I couldn't check with them.
Wasmtime GitHub notifications bot (Mar 22 2023 at 01:26):jameysharp requested elliottt for a review on PR #6084.
Wasmtime GitHub notifications bot (Mar 22 2023 at 01:26):jameysharp requested alexcrichton for a review on PR #6084.
Wasmtime GitHub notifications bot (Mar 22 2023 at 01:26):jameysharp requested pchickey for a review on PR #6084.
Wasmtime GitHub notifications bot (Mar 22 2023 at 01:26):jameysharp requested cfallin for a review on PR #6084.
Wasmtime GitHub notifications bot (Mar 22 2023 at 01:26):jameysharp requested fitzgen for a review on PR #6084.
Wasmtime GitHub notifications bot (Mar 22 2023 at 01:34):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Mar 22 2023 at 01:34):pchickey created PR review comment:
I think its worthwhile to break down the /crates further:
I will volunteer for component-macro, component-util, environ, fiber, runtime, test-programs, wasi, wasi-common, wasmtime, wiggle, wit-bindgenwasi-nn and wasi-threads are maintained by @abrown, I will be a secondary on these in case he is unavailable
winch is @saulecabrera
Wasmtime GitHub notifications bot (Mar 22 2023 at 02:28):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Mar 22 2023 at 14:11):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 22 2023 at 19:06):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Mar 22 2023 at 20:38):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Mar 23 2023 at 00:37):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Mar 23 2023 at 00:37):jameysharp created PR review comment:
I wanted to limit the number of people in this initial PR so we can start evaluating how well this works for the project as a whole. If Andrew or Saúl would like to make the time commitment described in this file, we can certainly add them later.
Also, keep in mind that I'm not expecting the people in this file to necessarily be the ideal reviewers for the areas covered. Instead they should be people who know who the right reviewer is and, more importantly, can quickly get a response out so a contributor isn't waiting a long time. So it isn't as important to be precise about who's handling which area. I think it's more important to keep the lists simple so it's easy to tell at a glance who might get handed what.
In particular, given that you've volunteered for a third of the directories in /crates, I think you have a good idea who to hand reviews off to for the rest. So if it's alright with you, I'll just add you to the rotation for the whole Wasmtime group and drop the WASI category.
Wasmtime GitHub notifications bot (Mar 23 2023 at 08:17):saulecabrera submitted PR review.
Wasmtime GitHub notifications bot (Mar 23 2023 at 08:17):saulecabrera created PR review comment:
@jameysharp I'm good with the time commitment described in this document and to be added to this list whenever you feel it's convenient. Thanks!
Wasmtime GitHub notifications bot (Mar 28 2023 at 17:45):jameysharp updated PR #6084 from codeowners to main.
Wasmtime GitHub notifications bot (Mar 28 2023 at 18:45):jameysharp merged PR #6084.
Last updated: Dec 23 2024 at 12:05 UTC