Stream: git-wasmtime

Topic: wasmtime / PR #6077 fuzzgen: Generate `call_indirect` ins...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2023 at 15:43):

afonso360 opened PR #6077 from fuzzgen-call-indirect to main:

:wave: Hey,

I completely forgot about adding this to fuzzgen after adding it to the interpreter in #5877. I've also noticed that we weren't assigning the call returns to any variables, so there is a second commit that fixes that.

We were also selecting calls with 32bit addresses, but ignoring the address type when inserting. I suppose it doesn't make that much of a difference, but this now rejects those calls and allows only 64bits. (Until we have a 32bit target!)

This is based on top of #5947 to avoid creating conflicts there. I don't mind rebasing it on main if we want to merge this before.

It's still fuzzing, but I'll update this if it finds something.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2023 at 15:43):

afonso360 requested jameysharp for a review on PR #6077.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2023 at 15:47):

afonso360 updated PR #6077 from fuzzgen-call-indirect to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2023 at 15:58):

afonso360 updated PR #6077 from fuzzgen-call-indirect to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2023 at 19:27):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2023 at 19:27):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2023 at 19:27):

jameysharp created PR review comment:

Call doesn't take any fixed value parameters, right? I think this exception is only necessary for CallIndirect, and it was okay that this wasn't in the exceptions list before.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2023 at 19:45):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2023 at 19:45):

afonso360 created PR review comment:

Oops, that's right

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2023 at 19:47):

afonso360 updated PR #6077 from fuzzgen-call-indirect to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 21 2023 at 19:47):

afonso360 edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2023 at 11:04):

afonso360 updated PR #6077 from fuzzgen-call-indirect to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2023 at 11:08):

afonso360 has enabled auto merge for PR #6077.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 22 2023 at 11:55):

afonso360 merged PR #6077.

Last updated: Nov 22 2024 at 17:03 UTC