afonso360 opened PR #6077 from fuzzgen-call-indirect
to main
:
:wave: Hey,
I completely forgot about adding this to fuzzgen after adding it to the interpreter in #5877. I've also noticed that we weren't assigning the call returns to any variables, so there is a second commit that fixes that.
We were also selecting calls with 32bit addresses, but ignoring the address type when inserting. I suppose it doesn't make that much of a difference, but this now rejects those calls and allows only 64bits. (Until we have a 32bit target!)
This is based on top of #5947 to avoid creating conflicts there. I don't mind rebasing it on main if we want to merge this before.
It's still fuzzing, but I'll update this if it finds something.
afonso360 requested jameysharp for a review on PR #6077.
afonso360 updated PR #6077 from fuzzgen-call-indirect
to main
.
afonso360 updated PR #6077 from fuzzgen-call-indirect
to main
.
jameysharp submitted PR review.
jameysharp submitted PR review.
jameysharp created PR review comment:
Call
doesn't take any fixed value parameters, right? I think this exception is only necessary forCallIndirect
, and it was okay that this wasn't in the exceptions list before.
afonso360 submitted PR review.
afonso360 created PR review comment:
Oops, that's right
afonso360 updated PR #6077 from fuzzgen-call-indirect
to main
.
afonso360 edited PR review comment.
afonso360 updated PR #6077 from fuzzgen-call-indirect
to main
.
afonso360 has enabled auto merge for PR #6077.
afonso360 merged PR #6077.
Last updated: Dec 23 2024 at 12:05 UTC