Stream: git-wasmtime

Topic: wasmtime / PR #6066 cranelift-entity: improve `EntitySet:...

Wasmtime GitHub notifications bot (Mar 20 2023 at 08:51):

maekawatoshiki edited PR #6066 from uint/dev to main:

This PR makes the changes mentioned at https://github.com/bytecodealliance/wasmtime/pull/5978 as future works. Effectively closes #5804.

Specifically, EntitySet::cardinality() implementation is modified for simplicity.

Wasmtime GitHub notifications bot (Mar 20 2023 at 23:31):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 20 2023 at 23:31):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 20 2023 at 23:31):

jameysharp created PR review comment:

Would you make this case be something greater than 64 instead of 42? That way it tests when len grows to a larger number of usize elements, and also when it shrinks back to the smaller number of elements.

If you make it 100, then we can also test that the values added below don't get double-counted when the underlying vector shrinks and re-grows.

Wasmtime GitHub notifications bot (Mar 20 2023 at 23:31):

jameysharp created PR review comment:

This test currently only adds values in ascending order. Let's check that it works out of order too:

        m.insert(E(1));
        assert!(m.cardinality() == 1);

        m.insert(E(0));
        assert!(m.cardinality() == 2);

        m.insert(E(1));
        assert!(m.cardinality() == 2);

Wasmtime GitHub notifications bot (Mar 21 2023 at 02:37):

maekawatoshiki updated PR #6066 from uint/dev to main.

Wasmtime GitHub notifications bot (Mar 21 2023 at 02:44):

maekawatoshiki updated PR #6066 from uint/dev to main.

Wasmtime GitHub notifications bot (Mar 21 2023 at 02:47):

maekawatoshiki requested jameysharp for a review on PR #6066.

Wasmtime GitHub notifications bot (Mar 21 2023 at 18:59):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 21 2023 at 19:39):

jameysharp merged PR #6066.

Last updated: Oct 23 2024 at 20:03 UTC