Stream: git-wasmtime

Topic: wasmtime / PR #6032 cranelift: simplify `x-x` to `0`

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:00):

Kmeakin opened PR #6032 from isub-self to main.

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:09):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:09):

fitzgen has enabled auto merge for PR #6032.

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:11):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:11):

cfallin created PR review comment:

This works great for all types except $I128, which for practical reasons (size of operator struct) isn't supported by iconst; so we need to guard this rule by a fits_in_64 pattern, as for x ^ x on line 113 below.

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:11):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:11):

cfallin has disabled auto merge for PR #6032.

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:21):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:21):

fitzgen created PR review comment:

Good catch, thanks!

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:23):

Kmeakin updated PR #6032 from isub-self to main.

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:27):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Mar 16 2023 at 20:27):

cfallin has enabled auto merge for PR #6032.

Wasmtime GitHub notifications bot (Mar 17 2023 at 14:51):

Kmeakin updated PR #6032 from isub-self to main.

Wasmtime GitHub notifications bot (Mar 17 2023 at 14:55):

alexcrichton has enabled auto merge for PR #6032.

Wasmtime GitHub notifications bot (Mar 17 2023 at 15:54):

alexcrichton merged PR #6032.

Last updated: Oct 23 2024 at 20:03 UTC