Stream: git-wasmtime

Topic: wasmtime / PR #6027 Rename `as_bool` to `as_truthy`, and ...

Wasmtime GitHub notifications bot (Mar 15 2023 at 19:25):

elliottt opened PR #6027 from trevor/rename-as-bool to main:

Rename the as_bool functions in cranelift-codegen-meta to as_truthy to
better describe their behavior. Additionally, fix the implementation of
TypeSet::as_truthy to match the behavior of Type::as_truthy, as it was
returning an empty TypeSet when it should have been mirroring the behavior.

This bug was introduced in #5013 when we removed booleans from cranelift.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 15 2023 at 19:26):

elliottt updated PR #6027 from trevor/rename-as-bool to main.

Wasmtime GitHub notifications bot (Mar 15 2023 at 19:27):

elliottt edited PR #6027 from trevor/rename-as-bool to main:

Rename the as_bool functions in cranelift-codegen-meta to as_truthy to better describe their behavior. Additionally, fix the implementation of TypeSet::as_truthy to match the behavior of Type::as_truthy, as it was returning an empty TypeSet when it should have been mirroring the behavior.

This bug was introduced in #5013 when we removed booleans from cranelift.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 15 2023 at 19:28):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Mar 15 2023 at 19:28):

elliottt created PR review comment:

Here's the bug fix for TypeSet::as_truthy. I've also updated the tests to ensure this is doing what we expect now, given the semantics of as_truthy_pedantic.

Wasmtime GitHub notifications bot (Mar 15 2023 at 19:29):

elliottt has marked PR #6027 as ready for review.

Wasmtime GitHub notifications bot (Mar 15 2023 at 19:29):

elliottt requested jameysharp for a review on PR #6027.

Wasmtime GitHub notifications bot (Mar 15 2023 at 19:32):

elliottt edited PR #6027 from trevor/rename-as-bool to main:

Rename the as_bool functions in cranelift-codegen-meta to as_truthy to better describe their behavior. Additionally, fix the implementation of TypeSet::as_truthy to match the behavior of Type::as_truthy, as it was returning an empty TypeSet when it should have been mirroring the behavior.

This bug was introduced in #5031 when we removed booleans from cranelift.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 17 2023 at 00:34):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 17 2023 at 21:59):

elliottt merged PR #6027.

Last updated: Dec 23 2024 at 12:05 UTC