Stream: git-wasmtime

Topic: wasmtime / PR #6024 perf: Create a per-process JIT dump file

Wasmtime GitHub notifications bot (Mar 15 2023 at 10:06):

bnjbvr opened PR #6024 from jitdump-multiple-engines to main:

We create a new JitDumpAgent per wasmtime::Engine,, and the former creates a new jit dump file in its constructor. Since the jit dump file name has to be unique and must follow the format expected by perf inject, the file name is a constant. This causes a bug that multiple Engines creations will clobber the jit dump file. Because of the file name requirement, we can't simply add a counter suffix in the jit dump file name, because then perf inject wouldn't find the files anymore.

Instead, we can use a single, per-process JIT dump file, that's shared across all the wasmtime::Engine; this works well in practice, and moves the mutex in JitDumpAgent in the outside world.

Wasmtime GitHub notifications bot (Mar 15 2023 at 14:04):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 15 2023 at 14:43):

alexcrichton merged PR #6024.

Last updated: Oct 23 2024 at 20:03 UTC