Stream: git-wasmtime

Topic: wasmtime / PR #6019 craelift: Compact cases in valid_for_...

Wasmtime GitHub notifications bot (Mar 14 2023 at 18:47):

elliottt opened PR #6019 from trevor/compact-valid-for-target-exceptions to main:

Compact down the cases in valid_for_target a bit by using or-patterns. In many cases, this means that we can express the exemptions of a single issue with one entry, rather than spreading them across many entries.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 14 2023 at 18:47):

elliottt requested afonso360 for a review on PR #6019.

Wasmtime GitHub notifications bot (Mar 14 2023 at 18:51):

elliottt updated PR #6019 from trevor/compact-valid-for-target-exceptions to main.

Wasmtime GitHub notifications bot (Mar 14 2023 at 18:51):

elliottt updated PR #6019 from trevor/compact-valid-for-target-exceptions to main.

Wasmtime GitHub notifications bot (Mar 14 2023 at 20:45):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Mar 14 2023 at 21:28):

afonso360 merged PR #6019.

Last updated: Oct 23 2024 at 20:03 UTC