Wasmtime GitHub notifications bot (Mar 14 2023 at 17:36): Wasmtime GitHub notifications bot (Mar 14 2023 at 17:36):elliottt opened PR #6018 from trevor/tighten-widen-narrow-constraints to main:
In #6013 we added support for two new constraints in the instruction DSL:
narrowerandwider. While these were meant to replace the special-case typechecking in the verifier, they didn't replicate the logic there exactly: both constraints would include the original control type in the sets they produced.This PR corrects this bug by excluding the control type in the type sets produced when constraining the control type with
narrowerandwider.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 14 2023 at 17:38):elliottt updated PR #6018 from trevor/tighten-widen-narrow-constraints to main.
Wasmtime GitHub notifications bot (Mar 14 2023 at 17:40):elliottt updated PR #6018 from trevor/tighten-widen-narrow-constraints to main.
Wasmtime GitHub notifications bot (Mar 14 2023 at 17:42):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Mar 14 2023 at 17:48):elliottt updated PR #6018 from trevor/tighten-widen-narrow-constraints to main.
Wasmtime GitHub notifications bot (Mar 14 2023 at 17:49):elliottt has enabled auto merge for PR #6018.
Wasmtime GitHub notifications bot (Mar 14 2023 at 18:43):elliottt merged PR #6018.
Last updated: Dec 23 2024 at 12:05 UTC