Stream: git-wasmtime

Topic: wasmtime / PR #6016 cranelift: Translate `stack_*` access...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2023 at 11:44):

afonso360 opened PR #6016 from unaligned-stack-store to main:

:wave: Hey,

We can't currently ensure that these will be aligned, so we shouldn't mark them as such. Once we have alignment specifiers it would be neat to check those and optimize these legalizations if possible.

Fixes #5922

view this post on Zulip Wasmtime GitHub notifications bot (Mar 14 2023 at 11:51):

afonso360 edited PR #6016 from unaligned-stack-store to main:

:wave: Hey,

We can't currently ensure that these will be aligned, so we shouldn't mark them as such. Once we have alignment specifiers it would be neat to check those and optimize these legalizations if possible.

See also the discussion on #5922 we may want to eventually make stack_{load,store} accept MemFlags directly, or remove the instructions entirely.

Fixes #5922

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2023 at 16:29):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 15 2023 at 18:39):

afonso360 merged PR #6016.

Last updated: Nov 22 2024 at 16:03 UTC