Stream: git-wasmtime

Topic: wasmtime / PR #6014 cranelift: Mark fpromote and fdemote ...

Wasmtime GitHub notifications bot (Mar 13 2023 at 23:30):

elliottt opened PR #6014 from trevor/fpromote-fdemote-vectors to main:

Mark fpromote and fdemote as not operating on scalars. This enforces the existing behavior in the backends, as no backend currently supports either of these instructions with vector arguments.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 13 2023 at 23:41):

elliottt edited PR #6014 from trevor/fpromote-fdemote-vectors to main:

Mark fpromote and fdemote as not operating on scalars. This enforces the existing behavior in the backends, as no backend currently supports either of these instructions with vector arguments. Tightening up the argument/result types in the instruction definitions will help with landing #5947, and opting more instructions into fuzzing automatically.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 14 2023 at 00:16):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 14 2023 at 01:29):

elliottt merged PR #6014.

Last updated: Nov 22 2024 at 17:03 UTC