Stream: git-wasmtime

Topic: wasmtime / PR #5995 Change CLIF `shuffle` to validate lan...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2023 at 19:02):

alexcrichton opened PR #5995 from validate-shuffle-immediate to main:

Previously the CLIF shuffle instruction did not perform any validation on the lane shuffle mask and specified that out-of-bounds lanes always returned 0 as the value. This behavior though is not required by WebAssembly which validates that lane indices are always in-bounds. Additionally since these are static immediates even other code generators should be able to verify that the immediates are in-bounds.

As a result this commit updates the definition of the shuffle instruction to specify that all byte immediates must be in-bounds in the range of [0, 32). The verifier has been updated and some test cases have been removed that were testing this functionality.

Closes #5989

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2023 at 15:22):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2023 at 15:23):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2023 at 15:23):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2023 at 19:01):

alexcrichton updated PR #5995 from validate-shuffle-immediate to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2023 at 15:04):

alexcrichton merged PR #5995.


Last updated: Dec 23 2024 at 13:07 UTC