Wasmtime GitHub notifications bot (Mar 11 2023 at 19:02): Wasmtime GitHub notifications bot (Mar 11 2023 at 19:02):alexcrichton opened PR #5995 from validate-shuffle-immediate to main:
Previously the CLIF
shuffleinstruction did not perform any validation on the lane shuffle mask and specified that out-of-bounds lanes always returned 0 as the value. This behavior though is not required by WebAssembly which validates that lane indices are always in-bounds. Additionally since these are static immediates even other code generators should be able to verify that the immediates are in-bounds.As a result this commit updates the definition of the
shuffleinstruction to specify that all byte immediates must be in-bounds in the range of [0, 32). The verifier has been updated and some test cases have been removed that were testing this functionality.Closes #5989
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 12 2023 at 15:22):afonso360 submitted PR review.
Wasmtime GitHub notifications bot (Mar 12 2023 at 15:23):afonso360 submitted PR review.
Wasmtime GitHub notifications bot (Mar 12 2023 at 15:23):afonso360 submitted PR review.
Wasmtime GitHub notifications bot (Mar 12 2023 at 19:01):alexcrichton updated PR #5995 from validate-shuffle-immediate to main.
Wasmtime GitHub notifications bot (Mar 13 2023 at 15:04):alexcrichton merged PR #5995.
Last updated: Nov 22 2024 at 17:03 UTC