Wasmtime GitHub notifications bot (Mar 11 2023 at 14:31): Wasmtime GitHub notifications bot (Mar 11 2023 at 14:31):afonso360 opened PR #5991 from implement-simd-arith to main:
:wave: Hey,
The interpreter can already deal with some opcodes in a polymorphic way, but this wasn't enabled for most binary and unary opcodes. This PR changes that. We get a bunch of opcodes implemented in a relatively easy way.
Please review this commit by commit, The first commits are just moving ops that weren't implemented from the main
simd-arithmetic.clifinto their own separate files. So that we could later enable that file for testing in the interpreter.Will add fuzzer support in a separate PR.
Wasmtime GitHub notifications bot (Mar 11 2023 at 14:31):afonso360 requested jameysharp for a review on PR #5991.
Wasmtime GitHub notifications bot (Mar 13 2023 at 19:22):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Mar 13 2023 at 19:22):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Mar 13 2023 at 19:22):jameysharp created PR review comment:
Pre-existing: should this comment have said "Same as
binary"?
Wasmtime GitHub notifications bot (Mar 15 2023 at 18:07):afonso360 submitted PR review.
Wasmtime GitHub notifications bot (Mar 15 2023 at 18:07):afonso360 created PR review comment:
Yeah, I think so, I'll update this when doing the refactoring above ^
Wasmtime GitHub notifications bot (Mar 16 2023 at 15:18):afonso360 updated PR #5991 from implement-simd-arith to main.
Wasmtime GitHub notifications bot (Mar 16 2023 at 15:19):afonso360 updated PR #5991 from implement-simd-arith to main.
Wasmtime GitHub notifications bot (Mar 16 2023 at 15:20):afonso360 updated PR #5991 from implement-simd-arith to main.
Wasmtime GitHub notifications bot (Mar 16 2023 at 16:33):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Mar 16 2023 at 22:13):alexcrichton merged PR #5991.
Last updated: Dec 23 2024 at 12:05 UTC