Stream: git-wasmtime

Topic: wasmtime / PR #5988 Fix some minor issues with the `explo...

Wasmtime GitHub notifications bot (Mar 11 2023 at 02:11):

alexcrichton opened PR #5988 from explorer to main:

This commit fixes a few minor issues that Nick and I ran into walking through some code with the wasmtime explore command:

• When a new function is reached the address map iterator is advanced past the prior function to avoid accidentally attributing instructions across functions.

• A < comparison was changed to <= to fix some off-by-one attributions from instructions to wasm instructions.

• The skipdata option is enabled in Capstone to avoid truncating AArch64 disassemblies too early.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 11 2023 at 02:11):

alexcrichton requested fitzgen for a review on PR #5988.

Wasmtime GitHub notifications bot (Mar 11 2023 at 02:20):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 11 2023 at 02:20):

fitzgen has enabled auto merge for PR #5988.

Wasmtime GitHub notifications bot (Mar 11 2023 at 03:06):

fitzgen merged PR #5988.

Last updated: Oct 23 2024 at 20:03 UTC