Wasmtime GitHub notifications bot (Mar 10 2023 at 23:26): Wasmtime GitHub notifications bot (Mar 10 2023 at 23:26):cfallin opened PR #5987 from fix-5985 to main:
One of the cases for a splat operation, as updated in #5370, wrote to a temp reg but then only conditionally transformed the temp into the final destination register. In another codepath,
rdwas left undefined. This causes a panic later when regalloc2 verifies SSA properties of its input (here, value not def'd before use).Fixes #5985.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 10 2023 at 23:26):cfallin requested elliottt for a review on PR #5987.
Wasmtime GitHub notifications bot (Mar 10 2023 at 23:42):cfallin requested fitzgen for a review on PR #5987.
Wasmtime GitHub notifications bot (Mar 11 2023 at 00:15):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Mar 11 2023 at 00:15):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Mar 11 2023 at 01:01):cfallin merged PR #5987.
Last updated: Nov 22 2024 at 16:03 UTC