Wasmtime GitHub notifications bot (Mar 10 2023 at 20:08): Wasmtime GitHub notifications bot (Mar 10 2023 at 20:08):afonso360 opened PR #5984 from riscv-codemotion to main:
:wave: Hey,
These are the code motion changes that are part of #5854. In the RISCV backend we have a bunch of unrelated rules scattered all over the place. This PR attempts to wrangle some order into some of these, mostly the ones that I noticed when working on #5854.
The best way to review this would be commit by commit, they are somewhat logical in what each one does.
Wasmtime GitHub notifications bot (Mar 10 2023 at 20:08):afonso360 requested jameysharp for a review on PR #5984.
Wasmtime GitHub notifications bot (Mar 13 2023 at 15:54):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Mar 13 2023 at 15:54):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Mar 13 2023 at 15:54):jameysharp created PR review comment:
Random thought while I'm looking at this: constructors like these could be marked
pure, I think. There's no need to change this if these are always used in impure contexts anyway though.
Wasmtime GitHub notifications bot (Mar 13 2023 at 15:54):jameysharp created PR review comment:
I guess
s32_add_fallibleought to move to the same place as the other add operations as well, but that doesn't have to happen in this PR.
Wasmtime GitHub notifications bot (Mar 13 2023 at 15:54):jameysharp created PR review comment:
On the one hand I'm tempted to suggest fixing "paramter" to "parameter" while we're here, and on the other hand I really like that this PR makes zero changes to anything it's moving. Hmm… I'll leave it up to you to decide :grin:
Wasmtime GitHub notifications bot (Mar 13 2023 at 18:45):afonso360 updated PR #5984 from riscv-codemotion to main.
Wasmtime GitHub notifications bot (Mar 13 2023 at 18:46):afonso360 has enabled auto merge for PR #5984.
Wasmtime GitHub notifications bot (Mar 13 2023 at 20:21):afonso360 merged PR #5984.
Last updated: Nov 22 2024 at 17:03 UTC