Stream: git-wasmtime

Topic: wasmtime / PR #5975 Introduce the `wasmtime-explorer` crate

Wasmtime GitHub notifications bot (Mar 10 2023 at 01:38):

fitzgen edited PR #5975 from explorer to main:

This implements Godbolt Compiler Explorer-like functionality for Wasmtime and Cranelift. Given a Wasm module, it compiles the module to native code and then writes a standalone HTML file that gives a split pane view between the WAT and ASM disassemblies.

THIS IS VERY MUCH AN MVP!!! Tons of stuff we could do with this, very little it actually does so far.

Usage:

$ wasmtime explore test.wasm -o test.explore.html
$ xdg-open test.explore.html

Once visiting the HTML page, you can hover over lines of WAT or asm and the corresponding lines will be highlighted. You can also click to scroll the corresponding line into view.

Here is a little screen recording, although the mouse itself isn't captured so it is a little hard to see what is going on:

Screencast from 2023-03-09 17-22-06.webm

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 10 2023 at 02:08):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 10 2023 at 02:08):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 10 2023 at 02:08):

jameysharp created PR review comment:

If you can get the TargetIsa here, we have a to_capstone method you can use instead of hard-coding that you want an x86 disassembler.

Wasmtime GitHub notifications bot (Mar 10 2023 at 02:08):

jameysharp created PR review comment:

You already mentioned it but I want to specifically highlight this change as needing to be reverted before this PR can merge.

Wasmtime GitHub notifications bot (Mar 10 2023 at 15:38):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 10 2023 at 21:29):

fitzgen updated PR #5975 from explorer to main.

Wasmtime GitHub notifications bot (Mar 10 2023 at 21:30):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Mar 10 2023 at 21:30):

fitzgen created PR review comment:

Unfortunately we don't have access to the TargetIsa here, but I did add the non-x86 cases.

Wasmtime GitHub notifications bot (Mar 10 2023 at 21:30):

fitzgen requested jameysharp for a review on PR #5975.

Wasmtime GitHub notifications bot (Mar 10 2023 at 21:30):

fitzgen requested alexcrichton for a review on PR #5975.

Wasmtime GitHub notifications bot (Mar 10 2023 at 21:54):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 10 2023 at 23:18):

fitzgen updated PR #5975 from explorer to main.

Wasmtime GitHub notifications bot (Mar 10 2023 at 23:18):

fitzgen has enabled auto merge for PR #5975.

Wasmtime GitHub notifications bot (Mar 11 2023 at 00:13):

fitzgen updated PR #5975 from explorer to main.

Wasmtime GitHub notifications bot (Mar 11 2023 at 00:14):

fitzgen has enabled auto merge for PR #5975.

Wasmtime GitHub notifications bot (Mar 11 2023 at 01:12):

fitzgen merged PR #5975.

Last updated: Dec 23 2024 at 12:05 UTC