Stream: git-wasmtime

Topic: wasmtime / PR #5956 Restrict fcvt_to_uint and fcvt_to_sin...

Wasmtime GitHub notifications bot (Mar 07 2023 at 21:19):

elliottt opened PR #5956 from trevor/fcvt-simd to main:

The fcvt_to_uint and fcvt_to_sint operations both lack lowerings that would
produce vectors on all backends. This PR tightens up the result type of both
instructions to no longer permit vector results.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 07 2023 at 21:19):

elliottt edited PR #5956 from trevor/fcvt-simd to main:

The fcvt_to_uint and fcvt_to_sint operations both lack lowerings that would produce vectors on all backends. This PR tightens up the result type of both instructions to no longer permit vector results.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 07 2023 at 23:30):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 07 2023 at 23:30):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 07 2023 at 23:30):

jameysharp created PR review comment:

I strongly sympathize with wanting to limit the scope of definitions, but introducing a block here is contrary to the prevailing style and I'm not convinced it makes this easier to understand. I would like to figure out how to fix the prevailing style so that it _is_ easier to understand, but I'd rather not do that in this PR. Would you drop the braces here?

Wasmtime GitHub notifications bot (Mar 07 2023 at 23:33):

elliottt updated PR #5956 from trevor/fcvt-simd to main.

Wasmtime GitHub notifications bot (Mar 07 2023 at 23:37):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Mar 08 2023 at 05:35):

elliottt merged PR #5956.

Last updated: Dec 23 2024 at 13:07 UTC