Stream: git-wasmtime

Topic: wasmtime / PR #5951 riscv64: Fix underflow in call reloca...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2023 at 12:31):

afonso360 opened PR #5951 from riscv-fix-call-reloc to main:

:wave: Hey,

Under some test case layouts the call relocation panicking with an underflow. Use wrapping_sub to signal that this is expected.

The fuzzer took a while to generate such a test case. And I can't introduce it as a regression test because when running via the regular clif-util run tests the layout is different and the test case passes!

I think this is because in the fuzzer we only add one trampoline, while in clif-util we build trampolines for each function in the file.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2023 at 12:31):

afonso360 requested jameysharp for a review on PR #5951.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 07 2023 at 12:31):

afonso360 edited PR #5951 from riscv-fix-call-reloc to main:

:wave: Hey,

Under some test case layouts the call relocation was panicking with an underflow. Use wrapping_sub to signal that this is expected.

The fuzzer took a while to generate such a test case. And I can't introduce it as a regression test because when running via the regular clif-util run tests the layout is different and the test case passes!

I think this is because in the fuzzer we only add one trampoline, while in clif-util we build trampolines for each function in the file.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2023 at 01:31):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 09 2023 at 18:58):

afonso360 updated PR #5951 from riscv-fix-call-reloc to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2023 at 11:18):

afonso360 updated PR #5951 from riscv-fix-call-reloc to main.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2023 at 11:22):

afonso360 has enabled auto merge for PR #5951.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 10 2023 at 12:28):

afonso360 merged PR #5951.


Last updated: Dec 23 2024 at 12:05 UTC