Stream: git-wasmtime

Topic: wasmtime / PR #5943 components: Assert sizes match `wit-p...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2023 at 20:02):

alexcrichton opened PR #5943 from assert-type-sizes to main:

I was debugging [an issue] recently where it appears that the underlying cause was a discrepancy in the size/align of a WIT type between Wasmtime and wit-parser. This commit adds compile-time assertions that the size of a WIT type is the same with wit-parser as it is in Wasmtime since the two have different systems to calculate the size of a type. The hope is that this will head off any future issues if they crop up.

[an issue]: https://github.com/bytecodealliance/wit-bindgen/issues/526

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2023 at 20:49):

alexcrichton requested pchickey for a review on PR #5943.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2023 at 21:38):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 08 2023 at 22:16):

alexcrichton merged PR #5943.


Last updated: Dec 23 2024 at 12:05 UTC