Stream: git-wasmtime

Topic: wasmtime / PR #5943 components: Assert sizes match `wit-p...

Wasmtime GitHub notifications bot (Mar 06 2023 at 20:02):

alexcrichton opened PR #5943 from assert-type-sizes to main:

I was debugging [an issue] recently where it appears that the underlying cause was a discrepancy in the size/align of a WIT type between Wasmtime and wit-parser. This commit adds compile-time assertions that the size of a WIT type is the same with wit-parser as it is in Wasmtime since the two have different systems to calculate the size of a type. The hope is that this will head off any future issues if they crop up.

[an issue]: https://github.com/bytecodealliance/wit-bindgen/issues/526

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 08 2023 at 20:49):

alexcrichton requested pchickey for a review on PR #5943.

Wasmtime GitHub notifications bot (Mar 08 2023 at 21:38):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Mar 08 2023 at 22:16):

alexcrichton merged PR #5943.

Last updated: Oct 23 2024 at 20:03 UTC