Stream: git-wasmtime

Topic: wasmtime / PR #5906 x64: Improve codegen for i8x16.shr_u

Wasmtime GitHub notifications bot (Mar 01 2023 at 20:22):

alexcrichton opened PR #5906 from x64-shr to main:

This catches a case that wasn't handled previously by #5880 to allow a constant load to be folded into an instruction rather than forcing it to be loaded into a temporary register.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 02 2023 at 00:18):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Mar 02 2023 at 00:18):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Mar 02 2023 at 00:18):

abrown created PR review comment:

Interesting that this isn't 0x7 but maybe the printer doesn't care because it doesn't really matter?

Wasmtime GitHub notifications bot (Mar 02 2023 at 00:18):

abrown created PR review comment:

I'm assuming these were here for padding and the removal of the instruction changes the offsets enough that the padding is unnecessary.

Wasmtime GitHub notifications bot (Mar 02 2023 at 05:43):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 02 2023 at 05:43):

alexcrichton created PR review comment:

Yeah I think this is capstone so my guess is that a less-than-10 heuristic or something like that is kicking in

Wasmtime GitHub notifications bot (Mar 02 2023 at 05:43):

alexcrichton created PR review comment:

I believe so!

Wasmtime GitHub notifications bot (Mar 02 2023 at 05:43):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Mar 02 2023 at 06:18):

alexcrichton merged PR #5906.

Last updated: Oct 23 2024 at 20:03 UTC