avanhatt opened PR #5904 from imm12neg
to main
:
Add a
precise-output
filetest for the unexpected behavior described in https://github.com/bytecodealliance/wasmtime/issues/5903 (immediates not being used for narrow widths).
jameysharp submitted PR review.
jameysharp has enabled auto merge for PR #5904.
jameysharp merged PR #5904.
bjorn3 submitted PR review.
bjorn3 created PR review comment:
Why doesn't the immediate here match the vcode?
jameysharp submitted PR review.
jameysharp created PR review comment:
Good question! I had to stare at this a minute after seeing your question. The vcode printed the instruction as
movn
, so storing bitwise-not of 0 intow2
. I guess the disassembler special-cased that to print a more "friendly" mnemonic for the instruction, where the bitwise-not is folded into the immediate value. I believe both are correct though, at least given a sufficiently clever assembler.
Last updated: Dec 23 2024 at 13:07 UTC