Stream: git-wasmtime

Topic: wasmtime / PR #5890 Change the name of wit-bindgen's host...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 27 2023 at 20:35):

sunfishcode opened PR #5890 from sunfishcode/host-trait-name to main:

Instead of naming the host implementation trait something like wasi_filesystem::WasiFilesystem, name it wasi_filesystem::Host, and avoid using the identifier Host in other places.

This fixes a collision when generating bindings for the current wasi-clock API, which contains an interface wall-clock which contains a type wall-clock, which created a naming collision on the name WallClock.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Feb 27 2023 at 20:47):

sunfishcode updated PR #5890 from sunfishcode/host-trait-name to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 27 2023 at 20:49):

sunfishcode updated PR #5890 from sunfishcode/host-trait-name to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 27 2023 at 21:03):

sunfishcode updated PR #5890 from sunfishcode/host-trait-name to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 27 2023 at 21:10):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 27 2023 at 23:50):

alexcrichton merged PR #5890.


Last updated: Dec 23 2024 at 13:07 UTC