Stream: git-wasmtime

Topic: wasmtime / PR #5890 Change the name of wit-bindgen's host...

Wasmtime GitHub notifications bot (Feb 27 2023 at 20:35):

sunfishcode opened PR #5890 from sunfishcode/host-trait-name to main:

Instead of naming the host implementation trait something like wasi_filesystem::WasiFilesystem, name it wasi_filesystem::Host, and avoid using the identifier Host in other places.

This fixes a collision when generating bindings for the current wasi-clock API, which contains an interface wall-clock which contains a type wall-clock, which created a naming collision on the name WallClock.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 27 2023 at 20:47):

sunfishcode updated PR #5890 from sunfishcode/host-trait-name to main.

Wasmtime GitHub notifications bot (Feb 27 2023 at 20:49):

sunfishcode updated PR #5890 from sunfishcode/host-trait-name to main.

Wasmtime GitHub notifications bot (Feb 27 2023 at 21:03):

sunfishcode updated PR #5890 from sunfishcode/host-trait-name to main.

Wasmtime GitHub notifications bot (Feb 27 2023 at 21:10):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 27 2023 at 23:50):

alexcrichton merged PR #5890.

Last updated: Nov 22 2024 at 16:03 UTC