Stream: git-wasmtime

Topic: wasmtime / PR #5889 Remove the `widening_pairwise_dot_pro...

Wasmtime GitHub notifications bot (Feb 27 2023 at 17:09):

alexcrichton opened PR #5889 from remove-widening-instruction to main:

This was added for the wasm SIMD proposal but I've been poking around at this recently and the instruction can instead be represented by its component parts with the same semantics I believe. This commit removes the instruction and instead represents it with the existing iadd_pairwise instruction (among others) and updates backends to with new pattern matches to have the same codegen as before.

This interestingly entirely removed the codegen rule with no replacement on the AArch64 backend as the existing rules all existed to produce the same codegen.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Feb 27 2023 at 17:43):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Feb 27 2023 at 19:22):

alexcrichton merged PR #5889.

Last updated: Nov 22 2024 at 17:03 UTC