Stream: git-wasmtime

Topic: wasmtime / PR #5885 fuzzgen: Initial SIMD support

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2023 at 15:09):

afonso360 opened PR #5885 from fuzz-simd to main:

:wave: Hey,

This PR Introduces support for SIMD vectors on fuzzgen. This is mostly to test ABI since it doesn't enable a lot of instructions.

I'm also not planning on introducing pretty much any other SIMD opcodes with the current opcode list system. I think the next step really is to move away from the opcode list.

This also does some changes to the clif file format. The current format represents consts as:

const0 = [0x00 0x01 0x02]

However, when printing a function we print in the following format:

const0 = 0x000102

And the file does not parse anymore. I.e. we are printing invalid CLIF when constants are involved.

It was easier for me to change the parser, than the printer. However if people prefer the old format, it should also be a fairly easy change.

Another option would be to start accepting both formats, which should also be fairly easy.

If anyone has opinions about this, let me know!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 26 2023 at 15:09):

afonso360 requested jameysharp for a review on PR #5885.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 27 2023 at 20:09):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 27 2023 at 20:09):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 27 2023 at 20:09):

jameysharp created PR review comment:

I think I'd rather place this check in the risc-v branch of the match triple.architecture below. You can place it before the exceptions! macro and do an early return false, or even say !is_simd && exceptions!(...) since the macro is just an expression evaluating to a bool.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 27 2023 at 20:09):

jameysharp created PR review comment:

How about a supports_simd variable instead of is_riscv?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2023 at 11:02):

afonso360 updated PR #5885 from fuzz-simd to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2023 at 11:20):

afonso360 has enabled auto merge for PR #5885.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 28 2023 at 13:00):

afonso360 merged PR #5885.

Last updated: Dec 23 2024 at 12:05 UTC