Stream: git-wasmtime

Topic: wasmtime / PR #5883 fuzzgen: Disable unaligned atomics fo...

Wasmtime GitHub notifications bot (Feb 25 2023 at 15:05):

afonso360 opened PR #5883 (assigned to jameysharp) from align-riscv-atomics to main:

:wave: Hey,

Fuzzgen found some issues on RISCV with unaligned atomic_rmw's (#5882). Lets disable them for now.

Wasmtime GitHub notifications bot (Feb 25 2023 at 15:05):

afonso360 assigned PR #5883 to jameysharp.

Wasmtime GitHub notifications bot (Feb 25 2023 at 18:23):

afonso360 updated PR #5883 (assigned to jameysharp) from align-riscv-atomics to main.

Wasmtime GitHub notifications bot (Feb 25 2023 at 18:24):

afonso360 edited PR #5883 (assigned to jameysharp) from align-riscv-atomics to main:

:wave: Hey,

Fuzzgen found some issues on RISCV with unaligned atomic_rmw's (#5882). Lets disable them for now.

Edit: And it turns out its not sufficient to just align addresses, the instruction is actually broken (#5884).

Wasmtime GitHub notifications bot (Feb 26 2023 at 14:52):

afonso360 updated PR #5883 (assigned to jameysharp) from align-riscv-atomics to main.

Wasmtime GitHub notifications bot (Feb 26 2023 at 14:53):

afonso360 updated PR #5883 (assigned to jameysharp) from align-riscv-atomics to main.

Wasmtime GitHub notifications bot (Feb 26 2023 at 15:39):

afonso360 updated PR #5883 (assigned to jameysharp) from align-riscv-atomics to main.

Wasmtime GitHub notifications bot (Feb 27 2023 at 18:27):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 27 2023 at 18:27):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 27 2023 at 18:27):

jameysharp created PR review comment:

I think I'd prefer to write this like so, phrased as "requires aligned" instead of "supports unaligned" and with the comment placed earlier:

        // Some backends have issues with unaligned atomics.
        // AArch64: https://github.com/bytecodealliance/wasmtime/issues/5483
        // RISCV: https://github.com/bytecodealliance/wasmtime/issues/5882
        let requires_aligned_atomics = matches!(
            self.target_triple.architecture,
            Architecture::Aarch64(_) | Architecture::Riscv64(_)
        );
        let aligned = if is_atomic && requires_aligned_atomics {

Wasmtime GitHub notifications bot (Feb 28 2023 at 10:22):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Feb 28 2023 at 10:22):

afonso360 created PR review comment:

Yeah that looks better, thanks!

Wasmtime GitHub notifications bot (Feb 28 2023 at 10:23):

afonso360 updated PR #5883 (assigned to jameysharp) from align-riscv-atomics to main.

Wasmtime GitHub notifications bot (Feb 28 2023 at 10:23):

afonso360 has enabled auto merge for PR #5883.

Wasmtime GitHub notifications bot (Feb 28 2023 at 11:41):

afonso360 merged PR #5883.

Last updated: Nov 22 2024 at 16:03 UTC