afonso360 opened PR #5883 (assigned to jameysharp) from align-riscv-atomics
to main
:
:wave: Hey,
Fuzzgen found some issues on RISCV with unaligned
atomic_rmw
's (#5882). Lets disable them for now.
afonso360 assigned PR #5883 to jameysharp.
afonso360 updated PR #5883 (assigned to jameysharp) from align-riscv-atomics
to main
.
afonso360 edited PR #5883 (assigned to jameysharp) from align-riscv-atomics
to main
:
:wave: Hey,
Fuzzgen found some issues on RISCV with unaligned
atomic_rmw
's (#5882). Lets disable them for now.Edit: And it turns out its not sufficient to just align addresses, the instruction is actually broken (#5884).
afonso360 updated PR #5883 (assigned to jameysharp) from align-riscv-atomics
to main
.
afonso360 updated PR #5883 (assigned to jameysharp) from align-riscv-atomics
to main
.
afonso360 updated PR #5883 (assigned to jameysharp) from align-riscv-atomics
to main
.
jameysharp submitted PR review.
jameysharp submitted PR review.
jameysharp created PR review comment:
I think I'd prefer to write this like so, phrased as "requires aligned" instead of "supports unaligned" and with the comment placed earlier:
// Some backends have issues with unaligned atomics. // AArch64: https://github.com/bytecodealliance/wasmtime/issues/5483 // RISCV: https://github.com/bytecodealliance/wasmtime/issues/5882 let requires_aligned_atomics = matches!( self.target_triple.architecture, Architecture::Aarch64(_) | Architecture::Riscv64(_) ); let aligned = if is_atomic && requires_aligned_atomics {
afonso360 submitted PR review.
afonso360 created PR review comment:
Yeah that looks better, thanks!
afonso360 updated PR #5883 (assigned to jameysharp) from align-riscv-atomics
to main
.
afonso360 has enabled auto merge for PR #5883.
afonso360 merged PR #5883.
Last updated: Dec 23 2024 at 13:07 UTC