Stream: git-wasmtime

Topic: wasmtime / PR #5877 cranelift-interpreter: Implement `cal...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 24 2023 at 16:29):

afonso360 opened PR #5877 from interp-func-addr to main:

:wave: Hey,

This PR implements call_indirect and return_call_indirect in the interpreter.

I'm not too happy with how this turned out, I think there is a way of making the function references and the address round tripping a bit cleaner but I'm not seeing how right now.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 24 2023 at 16:29):

afonso360 requested jameysharp for a review on PR #5877.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 24 2023 at 19:54):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 24 2023 at 19:54):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 24 2023 at 19:54):

jameysharp created PR review comment:

Minor typo, but this type name appears a bunch of places in this PR:

pub enum InterpreterFunctionRef<'a> {

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2023 at 12:45):

afonso360 updated PR #5877 from interp-func-addr to main.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2023 at 12:48):

afonso360 has enabled auto merge for PR #5877.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 25 2023 at 13:59):

afonso360 merged PR #5877.

Last updated: Nov 22 2024 at 17:03 UTC