Stream: git-wasmtime

Topic: wasmtime / PR #5873 fix codegen riscv64 normalize_cmp_va...

Wasmtime GitHub notifications bot (Feb 27 2023 at 03:09):

yuyang-ok edited PR #5873 from issue5839 to main:

This will try fix https://github.com/bytecodealliance/wasmtime/issues/5839
The normalize_cmp_value should accept IntCC as extra parameter.
So we can know If should signed extend or unsigned extend on int types.
Riscv64 can only compare int64 value.

Wasmtime GitHub notifications bot (Feb 27 2023 at 04:25):

yuyang-ok updated PR #5873 from issue5839 to main.

Wasmtime GitHub notifications bot (Feb 27 2023 at 04:25):

yuyang-ok has marked PR #5873 as ready for review.

Wasmtime GitHub notifications bot (Feb 27 2023 at 11:12):

yuyang-ok updated PR #5873 from issue5839 to main.

Wasmtime GitHub notifications bot (Feb 27 2023 at 12:00):

yuyang-ok updated PR #5873 from issue5839 to main.

Wasmtime GitHub notifications bot (Feb 28 2023 at 07:16):

yuyang-ok updated PR #5873 from issue5839 to main.

Wasmtime GitHub notifications bot (Feb 28 2023 at 13:16):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 28 2023 at 13:16):

jameysharp created PR review comment:

Very small style fix: let's add one space after the rule priority. Also, can't this have priority 1? I'm not sure why it's 2. I don't see any other rules with priority 1.

(rule 1 (normalize_cmp_value (fits_in_32 ity) r op)

Wasmtime GitHub notifications bot (Feb 28 2023 at 13:16):

jameysharp created PR review comment:

Since only one rule needs this conversion, I would prefer to do the conversion explicitly and remove the (convert) directive.

  (let ((a Reg (normalize_cmp_value in_ty a (intcc_to_extend_op cc)))
        (b Reg (normalize_cmp_value in_ty b (intcc_to_extend_op cc))))

Wasmtime GitHub notifications bot (Feb 28 2023 at 13:16):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 28 2023 at 13:21):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Feb 28 2023 at 22:25):

yuyang-ok updated PR #5873 from issue5839 to main.

Wasmtime GitHub notifications bot (Feb 28 2023 at 22:26):

yuyang-ok updated PR #5873 from issue5839 to main.

Wasmtime GitHub notifications bot (Feb 28 2023 at 22:29):

yuyang-ok updated PR #5873 from issue5839 to main.

Wasmtime GitHub notifications bot (Feb 28 2023 at 22:30):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Feb 28 2023 at 22:30):

jameysharp has enabled auto merge for PR #5873.

Wasmtime GitHub notifications bot (Feb 28 2023 at 23:37):

jameysharp merged PR #5873.

Last updated: Nov 22 2024 at 17:03 UTC