Wasmtime GitHub notifications bot (Feb 24 2023 at 00:19): Wasmtime GitHub notifications bot (Feb 24 2023 at 00:19):elliottt opened PR #5872 from trevor/runtests-trigger-all-backends to main:
As any backend can be affected by modifying runtests, test all backends when one of them is modified.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 24 2023 at 00:35):elliottt updated PR #5872 from trevor/runtests-trigger-all-backends to main.
Wasmtime GitHub notifications bot (Feb 24 2023 at 00:43):elliottt updated PR #5872 from trevor/runtests-trigger-all-backends to main.
Wasmtime GitHub notifications bot (Feb 24 2023 at 00:45):elliottt has marked PR #5872 as ready for review.
Wasmtime GitHub notifications bot (Feb 24 2023 at 00:45):elliottt requested alexcrichton for a review on PR #5872.
Wasmtime GitHub notifications bot (Feb 24 2023 at 00:45):elliottt edited PR #5872 from trevor/runtests-trigger-all-backends to main:
As any backend can be affected by modifying runtests, test all backends when one of them is modified.
I tested this by making a change to a runtest file and reverting it, to verify that all backends were tested when that file was changed.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Feb 24 2023 at 15:39):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 24 2023 at 18:28):alexcrichton merged PR #5872.
Last updated: Nov 22 2024 at 16:03 UTC