Stream: git-wasmtime

Topic: wasmtime / PR #5871 Fix a panic due to a race in unpark a...

Wasmtime GitHub notifications bot (Feb 23 2023 at 22:41):

alexcrichton opened PR #5871 from fix-unpark-panic to main:

This commit fixes a panic in the ParkingSpot implementation where an
unpark signal may not get acknowledged when a waiter times out,
causing the waiter to remove itself from the internal map but panic
thinking that it missed an unpark signal.

The fix in this commit is to consume unpark signals when a timeout
happens. This can lead to another possible race I've detailed in the
comments which I believe is allowed by the specification of park/unpark
in wasm.

Wasmtime GitHub notifications bot (Feb 23 2023 at 22:51):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Feb 23 2023 at 22:51):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Feb 23 2023 at 22:51):

abrown created PR review comment:

                // getting unparked. For example:

Wasmtime GitHub notifications bot (Feb 23 2023 at 22:52):

alexcrichton updated PR #5871 from fix-unpark-panic to main.

Wasmtime GitHub notifications bot (Feb 23 2023 at 22:52):

alexcrichton has enabled auto merge for PR #5871.

Wasmtime GitHub notifications bot (Feb 24 2023 at 00:44):

alexcrichton merged PR #5871.

Last updated: Dec 23 2024 at 13:07 UTC